Skip to content

Commit c60eb45

Browse files
authored
Merge pull request #80 from spacesvr/dev
v1.9.1
2 parents deeb550 + 8845a51 commit c60eb45

File tree

5 files changed

+7
-12
lines changed

5 files changed

+7
-12
lines changed

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "spacesvr",
3-
"version": "1.9.0",
3+
"version": "1.9.1",
44
"private": true,
55
"description": "An Environment for WebXR Spaces",
66
"keywords": [

src/ideas/components/Image.tsx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,6 @@ function UnsuspensedImage(props: ImageProps) {
5151
thickness={frameWidth}
5252
material={frameMaterial}
5353
innerFrameMaterial={innerFrameMaterial}
54-
transparent={transparent}
5554
/>
5655
)}
5756
</group>

src/ideas/misc/Frame.tsx

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@ type FrameProps = {
1313
thickness?: number;
1414
material?: Material;
1515
innerFrameMaterial?: Material;
16-
transparent?: boolean;
1716
};
1817

1918
/**
@@ -33,7 +32,6 @@ export default function Frame(props: FrameProps) {
3332
height,
3433
thickness = 1,
3534
material: passedMaterial,
36-
transparent = false,
3735
innerFrameMaterial,
3836
} = props;
3937

@@ -102,11 +100,7 @@ export default function Frame(props: FrameProps) {
102100
0
103101
);
104102

105-
const geos = [topFrame, bottomFrame, leftFrame, rightFrame];
106-
107-
if (!innerFrameMaterial && !transparent) {
108-
geos.unshift(backPanel);
109-
}
103+
const geos = [backPanel, topFrame, bottomFrame, leftFrame, rightFrame];
110104

111105
const geo = BufferGeometryUtils.mergeBufferGeometries(geos);
112106

@@ -117,7 +111,7 @@ export default function Frame(props: FrameProps) {
117111
rightFrame.dispose();
118112

119113
return geo;
120-
}, [innerFrameMaterial, transparent, borderThickness, width, height]);
114+
}, [innerFrameMaterial, borderThickness, width, height]);
121115

122116
const backFrameGeometry = useMemo<BufferGeometry | undefined>(() => {
123117
if (!innerFrameMaterial) return undefined;

src/layers/reality/ui/PauseMenu/index.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ export default function PauseMenu(props: PauseMenuProps) {
5353
const PAUSE_ITEMS: PauseItem[] = [
5454
...pauseMenuItems,
5555
{
56-
text: "v1.9.0",
56+
text: "v1.9.1",
5757
link: "https://www.npmjs.com/package/spacesvr",
5858
},
5959
...menuItems,

src/layers/reality/utils/menu.tsx

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ export function RegisterMenuItems() {
3434

3535
export const useVRMenuItem = (): MenuItem | undefined => {
3636
const gl = useThree((state) => state.gl);
37-
const { setDevice } = useEnvironment();
37+
const { setDevice, setPaused } = useEnvironment();
3838

3939
// @ts-ignore
4040
const xr = navigator.xr;
@@ -67,13 +67,15 @@ export const useVRMenuItem = (): MenuItem | undefined => {
6767
await gl.xr.setSession(sesh);
6868
setText("Exit VR");
6969
setDevice("xr");
70+
setPaused(false);
7071
session.current = sesh;
7172
}
7273

7374
function onSessionEnded() {
7475
session.current?.removeEventListener("end", onSessionEnded);
7576
setDevice(isMobile ? "mobile" : "desktop");
7677
setText("Enter VR");
78+
setPaused(true);
7779
session.current = undefined;
7880
}
7981

0 commit comments

Comments
 (0)