Skip to content

Adding user-agent header #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 2, 2024
Merged

Adding user-agent header #52

merged 3 commits into from
Jul 2, 2024

Conversation

JacquiManzi
Copy link
Contributor

Adding a user agent header to our Tesla Client.

@JacquiManzi JacquiManzi requested a review from a team as a code owner June 20, 2024 22:52
jsanford8
jsanford8 approved these changes Jun 21, 2024
View reviewed changes
Copy link
Contributor

@jsanford8 jsanford8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

assuming this works, the code lgtm

philcluff
philcluff requested changes Jun 21, 2024
View reviewed changes
Copy link
Contributor

@philcluff philcluff left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry to nit, but let's keep this consistent with the other server-side SDKs, and use Mux Elixir ?

@jsanford8
Copy link
Contributor

Okay so we have a handful of things out there, we should decide what we want to conform to and make that happen. The formats we have so far are:

Mux <language> | <version>
OpenAPI-Generator/<version>/<language>
Mux/JS <version>

Should we just make everything conform to Mux <language> | <version>?

@philcluff
Copy link
Contributor

IMO yes, there was a point in time where they were all aligned, but they've diverged :(

@jsanford8
Copy link
Contributor

works for me

@JacquiManzi JacquiManzi merged commit 05ae672 into master Jul 2, 2024
1 check passed
@JacquiManzi JacquiManzi deleted the jm-add-user-agent branch July 2, 2024 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philcluff philcluff philcluff requested changes

@jsanford8 jsanford8 jsanford8 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JacquiManzi @jsanford8 @philcluff