Skip to content

Close log file before cleanup operations #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 23, 2025
Merged

Close log file before cleanup operations #67

merged 2 commits into from
Jul 23, 2025

Conversation

besendorf
Copy link
Collaborator

fixes #54
However the last few lines of the command.log are missing.

roaree
roaree approved these changes Jul 22, 2025
View reviewed changes
Copy link
Collaborator

@roaree roaree left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Would it make sense to instead call defer log.CloseFileLog() somewhere else at the start of the run? This would avoid not having to worry about whether every possible execution path closes the log file. I defer to your judgement :)

@besendorf
Copy link
Collaborator Author

Took a while until I got the pun ;). Indeed defer is the better approach.

@besendorf besendorf merged commit 02070c6 into main Jul 23, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roaree roaree roaree approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Age Encryption failed
2 participants
@besendorf @roaree