Hide the processing section of "Tasks" dialogs based on backend configuration #1331
Conversation
| self.in_interleave = None | ||
| self.sub_wedge_size = 10 | ||
|
|
||
| self.disable_processing = False |
There was a problem hiding this comment.
Sure, why not. Is this a UI option or more a feature that you also which to use on the backend. Do you actually want to disable processing or always call the same processing ?
There was a problem hiding this comment.
Right now, it’s just used to hide something in the UI that isn’t needed, but I can imagine a use case where this information could be used by the backend to decide whether to start processing
There was a problem hiding this comment.
Ok, sounds good. Should we make it configurable then so that its read from the beamline_config.yaml ? There is already a section for similair settings
There was a problem hiding this comment.
If you follow this link mxcube/mxcubeweb#1782 (comment), you’ll see the implementation in mxcubeweb.
You can already configure it from the beamline_config.yaml. I chose to place it under the default_acquisition_parameters section, but there might be a better place.
I chose that section so it could be disabled depending on the method.
Example:
...
default_acquisition_parameters:
default:
...
take_snapshots: true
sub_wedge_size: 10
+ disable_processing: true
...There was a problem hiding this comment.
Ok, lets keep it like that :)
There was a problem hiding this comment.
To make it clearer, I could update the beamline_config.yaml file by adding the line disable_processing: false. It's not really necessary since "false" is the default, but it helps show how to configure the setting.
|
Looks good to me, please rebase and merge :) |
…frontend to hide the processing section in the "Tasks" dialogs
alessandro-olivo
force-pushed
the
ao-feature-hide_processing_task_section
branch
from
9a7331e to
310b91a
Compare
|
@marcus-oscarsson A review is needed before I can merge |
This PR is required for the PR: mxcube/mxcubeweb#1782 (follow the link for details)