Skip to content

Hide the processing section of "Tasks" dialogs based on backend configuration #1331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 15, 2025
Merged

Hide the processing section of "Tasks" dialogs based on backend configuration #1331

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion mxcubecore/model/queue_model_objects.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1715,7 +1715,7 @@ def __init__(self):
self.in_queue = False
self.in_interleave = None
self.sub_wedge_size = 10

self.disable_processing = False
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, why not. Is this a UI option or more a feature that you also which to use on the backend. Do you actually want to disable processing or always call the same processing ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right now, it’s just used to hide something in the UI that isn’t needed, but I can imagine a use case where this information could be used by the backend to decide whether to start processing

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, sounds good. Should we make it configurable then so that its read from the beamline_config.yaml ? There is already a section for similair settings

Copy link
Contributor Author

@alessandro-olivo alessandro-olivo Jul 15, 2025 •
edited by fabcor-maxiv
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you follow this link mxcube/mxcubeweb#1782 (comment), you’ll see the implementation in mxcubeweb.
You can already configure it from the beamline_config.yaml. I chose to place it under the default_acquisition_parameters section, but there might be a better place.
I chose that section so it could be disabled depending on the method.

Example:

   ...
  default_acquisition_parameters:
    default:
      ...
      take_snapshots: true
      sub_wedge_size: 10
+     disable_processing: true
      ...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, lets keep it like that :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To make it clearer, I could update the beamline_config.yaml file by adding the line disable_processing: false. It's not really necessary since "false" is the default, but it helps show how to configure the setting.

self.num_triggers = int()
self.num_images_per_trigger = int()
self.hare_num = 1
Expand Down Expand Up @@ -1765,6 +1765,7 @@ def as_dict(self):
"mesh_center": self.mesh_center,
"cell_spacing": self.cell_spacing,
"sub_wedge_size": self.sub_wedge_size,
"disable_processing": self.disable_processing,
}

def copy(self):
Expand Down