SSRF BL19U1 Beamline #1368
Open
SSRF BL19U1 Beamline #1368
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2、发现一个response的拼写错误，已改正
…nt的一个状态设置为disabled
rhfogh
requested changes
Sep 8, 2025
There was a problem hiding this comment.
This is very welcome, but something is wrong here.
- There are changes in 2651 files, and it looks like every line in every file is changed (according to the github diff program).
- Comparing the two branches on my local machine (in pycharm) it looks like the bao branch has some very old versions of the files I looked at (GPhL code). The comment on tha bao branch in gitub says "This branch is 168 commits ahead of, 1539 commits behind mxcube/mxcubecore:develop."
- My editor seems to suggests that the bao files are using CR;LF as line separators (as in windows files) whereas we have standardised on linux line separators.
It could be that - this being the first (?) PR from SSRF - the procedure needs adjusting. Could you rebase (preferably) cherry-pick, or merge so that the branch being pushed is completely ahead of the mxcubecore develop branch, and also check that you are using the right line separators?
|
As you just opened #1369 does it mean that we can close this one ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upload SSRF BL19U1 Beamline mxcubecore code