Skip to content

Conversation

Baokangwen
Copy link

I have re-uploaded the configuration file for our line station separately. The branch I uploaded yesterday, can you help us create a separate branch? This way, it will be more convenient for us to submit code. We have been developing locally before and haven't been following your pace all along.

BL19U1 beamline configure file
Add ssrf bl19u1 beamline xml configure file.
@marcus-oscarsson
Copy link
Member

As @rhfogh pointed out yesterday we are all really happy to see your first contributions. Congratulations !, and we are looking forward to more of these :).

For the PR it self, you should be able to create a branch on the repository if that is what you like. If not you can keep working from your fork, its a personal choice/preference.

I noticed that there are few linting errors, it seems like its mostly white spaces, I think they can be fixed by simply running pre-commit run --all-files in your shell.

I hope it helps ?

@Baokangwen
Copy link
Author

As @rhfogh pointed out yesterday we are all really happy to see your first contributions. Congratulations !, and we are looking forward to more of these :).

For the PR it self, you should be able to create a branch on the repository if that is what you like. If not you can keep working from your fork, its a personal choice/preference.

I noticed that there are few linting errors, it seems like its mostly white spaces, I think they can be fixed by simply running pre-commit run --all-files in your shell.

I hope it helps ?

Thank you Marcus.Just as I wanted to ask a question.After last Friday's meeting, I sent you an email regarding MXCuBE automated data collection. We noticed that if the 3-click centering is not performed, the system stops and waits until we manually generate the collection point. Could you advise on how to automatically generate the collection point during the automated data collection process?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants