-
Notifications
You must be signed in to change notification settings - Fork 44
Description
In SampleViewContainer
component there is a property
cellCounting: state.taskForm.defaultParameters.mesh.cell_counting, |
which is set in the
beamline_config.yml
- under the default_acquisition_parameters.mesh
key: mxcubeweb/demo.yaml/beamline_config.yml
Line 121 in 6bf391b
cell_counting: zig-zag |
Which is then retrieved and stored like so:
mxcubeweb/mxcubeweb/core/components/queue.py
Lines 2212 to 2233 in 6bf391b
return { | |
"acq_parameters": { | |
**acq_parameters, | |
"inverse_beam": False, | |
"take_dark_current": True, | |
"skip_existing_images": False, | |
"take_snapshots": HWR.beamline.collect.get_property( | |
"num_snapshots", self.app.DEFAULT_NUM_SNAPSHOTS | |
), | |
"helical": False, | |
"mesh": False, | |
"prefixTemplate": "{PREFIX}_{POSITION}", | |
"subDirTemplate": "{ACRONYM}/{ACRONYM}-{NAME}", | |
"experiment_type": "", | |
}, | |
"limits": HWR.beamline.config.acquisition_limit_values, | |
"requires": requires if requires else [], | |
"name": display_name if display_name else task_name, | |
"queue_entry": task_name, | |
"schema": schema, | |
"ui_schema": ui_schema, | |
} |
mxcubeweb/ui/src/actions/login.js
Lines 116 to 118 in 6bf391b
fetchAvailableTasks() | |
.then((taskParameters) => ({ taskParameters })) | |
.catch(notify), |
mxcubeweb/ui/src/reducers/taskForm.js
Lines 34 to 41 in 6bf391b
case 'SET_INITIAL_STATE': { | |
return { | |
...state, | |
defaultParameters: { | |
...action.data.taskParameters, | |
}, | |
fileSuffix: action.data.detector.fileSuffix, | |
}; |
That is: the cellCounting
should be read like so:
cellCounting: state.taskForm.defaultParameters.mesh.acq_parameters.cell_counting,
Currently it seems to be always set to undefined
. It also seems to be this way for a long time (at least 3 years I think, probably since this commit: 8bdec8e )
I wonder if perhaps this is no longer used? If so, I could remove references to it (it's currently used only in DrawGridPlugin
).
In other case; I guess I will make it be read in a way I've mentioned above.
Related comment: #1808 (comment)