-
Notifications
You must be signed in to change notification settings - Fork 44
Hide the processing section of "Tasks" dialogs based on backend configuration #1782
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hide the processing section of "Tasks" dialogs based on backend configuration #1782
Conversation
28a2edf
to
ec61335
Compare
ec61335
to
c4347a2
Compare
Since this depends on mxcube/mxcubecore#1331, which has been merged by now, could you update the version of mxcubecore in Afterwards, I guess you can rebase and merge:) |
Perfect, yes please go-ahead and re-base and merge |
c0b103a
to
7dcd0c3
Compare
I've updated the tests, but there's still an issue with the CI checks. I think it might be related to the configuration, since the warning says: |
To me it seems that the problem is not directly the configuration, but the SonarQube token is needed for running the SonarQube CI. The token itself is set in the repo's secrets for the action to pick it up. However, GitHub is not passing secrets to a fork; hence, you cannot run the workflow on your PR, but it runs on all PRs done from a branch inside the repo. However, it will correctly run when we push the changes to develop. This is indeed a problem, we have not thought about when introducing it recently #1774 . As of now, I recon we can ignore it, the check is not required to pass anyways. Then we probably need to find a solution like only running it on a push. |
Sorry, I was merging the current open PRs but should have started with this one. Could you rebase again @alessandro-olivo ? |
…nd configuration; Bump the required mxcubecore version
b7fa2d6
to
a219731
Compare
@marcus-oscarsson Done! :) |
Thanks @alessandro-olivo |
This feature allows hiding the "processing" section in the Task dialogs (i.e. DataCollection, Helical, and Mesh) based on the new acquisition parameter
disable_processing
that can be configured from the backend.HowTo
Update your
beamline_config.yaml
file like this:Requirements