Skip to content

Conversation

alessandro-olivo
Copy link
Contributor

@alessandro-olivo alessandro-olivo commented Jul 15, 2025

This feature allows hiding the "processing" section in the Task dialogs (i.e. DataCollection, Helical, and Mesh) based on the new acquisition parameter disable_processing that can be configured from the backend.

HowTo

Update your beamline_config.yaml file like this:

   ...
  default_acquisition_parameters:
    default:
      ...
      take_snapshots: true
      sub_wedge_size: 10
+     disable_processing: false
      ...

      helical:
        # Defaults for helical scan. Missing values are taken from default
        number_of_images: 100
+       disable_processing: true

The first disable_processing: false is not actually needed since "false" is the default value when not explicitly set in this file.

Requirements

⚠️ This PR depends on mxcube/mxcubecore#1331 (merge this first)

@alessandro-olivo alessandro-olivo force-pushed the ao-feature-hide_processing_task_section branch from ec61335 to c4347a2 Compare July 15, 2025 14:02
@walesch-yan
Copy link
Collaborator

Since this depends on mxcube/mxcubecore#1331, which has been merged by now, could you update the version of mxcubecore in pyproject.toml to the one that includes your backend changes? (should be 1.335.0)

Afterwards, I guess you can rebase and merge:)

@marcus-oscarsson
Copy link
Member

Perfect, yes please go-ahead and re-base and merge

@alessandro-olivo alessandro-olivo force-pushed the ao-feature-hide_processing_task_section branch 2 times, most recently from c0b103a to 7dcd0c3 Compare July 17, 2025 08:58
@alessandro-olivo
Copy link
Contributor Author

I've updated the tests, but there's still an issue with the CI checks. I think it might be related to the configuration, since the warning says: Set the SONAR_TOKEN env variable.

@walesch-yan
Copy link
Collaborator

To me it seems that the problem is not directly the configuration, but the SonarQube token is needed for running the SonarQube CI. The token itself is set in the repo's secrets for the action to pick it up. However, GitHub is not passing secrets to a fork; hence, you cannot run the workflow on your PR, but it runs on all PRs done from a branch inside the repo. However, it will correctly run when we push the changes to develop.

This is indeed a problem, we have not thought about when introducing it recently #1774 . As of now, I recon we can ignore it, the check is not required to pass anyways. Then we probably need to find a solution like only running it on a push.

@walesch-yan
Copy link
Collaborator

Sorry, I was merging the current open PRs but should have started with this one. Could you rebase again @alessandro-olivo ?

@alessandro-olivo alessandro-olivo force-pushed the ao-feature-hide_processing_task_section branch from b7fa2d6 to a219731 Compare July 17, 2025 12:18
@alessandro-olivo
Copy link
Contributor Author

alessandro-olivo commented Jul 17, 2025

@marcus-oscarsson Done! :)

@walesch-yan
Copy link
Collaborator

Thanks @alessandro-olivo

@walesch-yan walesch-yan merged commit cad180d into mxcube:develop Jul 17, 2025
12 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants