Removing View results and View results in IPSYB
#1790
Conversation
dominikatrojanowska
changed the title
View results in IPSYBView results and View results in IPSYB
dominikatrojanowska
force-pushed
the
dt-show-results-url
branch
from
6247eb4 to
8e447e8
Compare
|
Great @dominikatrojanowska, thank. Starts to look quite complete |
dominikatrojanowska
force-pushed
the
dt-show-results-url
branch
4 times, most recently
from
0a2a013 to
c265a6e
Compare
dominikatrojanowska
force-pushed
the
dt-show-results-url
branch
from
c265a6e to
bd034e3
Compare
|
I think this is rather complete, you are missing this though: For all Queue items except for Characterization, where we still use the result (but its not the LIMS result) |
it is related to showing up the |
|
So, I'm not sure, but since we removed the link, isn't the |
dominikatrojanowska
force-pushed
the
dt-show-results-url
branch
from
bd034e3 to
de34d10
Compare
I've just checked twice, indeed it doesn't make sense to keep it |
| className="p-2" | ||
| id="taskSummaryPopover" | ||
| title={<b>{this.title()}</b>} | ||
| > | ||
| <LimsResultSummary taskData={this.props.taskData} scale="0.5" /> | ||
| </Popover> | ||
| /> |
There was a problem hiding this comment.
Oh I see, I was not aware of this. This here might be useful as it is a popover for the tasks in the sampleGrid tab:
So, I think we can keep that, as it can serve as a reminder, for the parameters set in the scheduled tasks.
Sorry, I was overlooking this before. I also don't really know if anybody uses this, so I would advocate to keep it but maybe change the name of LimsResultSummary in that case, as it's more of a summary of parameters? But I do not have a strong opinion on this, so if you think it makes sense to remove it, we can do that
There was a problem hiding this comment.
ok, I wasn't aware of it too, I can revert this part back then.
There was a problem hiding this comment.
No, it's in this repo and available in the mockup.
To see it, you have to:
- Add a task to the queue (i.e. either from SampleView or by right-clicking on the Item in
SampleGrid(the item framed in the bordered line above and click add DataCollection)) - A small Badge (In the picture the one saying 'DC') will be added to the Item, which you can hover over to see the overview.
Normally, for every task you add, there will be a Badge. In the SampleView you have a better overview of them in general, but for the SampleGrid tab, this Popover might be useful:)
dominikatrojanowska
force-pushed
the
dt-show-results-url
branch
from
de34d10 to
9050bcc
Compare
There was a problem hiding this comment.
Thanks @dominikatrojanowska, this looks pretty complete to me now
|
#1790 (comment) |
Accordingly to the discussion mxcube#1773 limsResultData was removed from the backend signals' messages in mxcube@6af4e5d
…B and related code as a continuation of Removing View results and View results in IPSYB and discussion: mxcube#1773 and removed backend singals: mxcube@6af4e5d
dominikatrojanowska
force-pushed
the
dt-show-results-url
branch
from
4cf87fd to
5e5e7be
Compare
|
Thanks @dominikatrojanowska, I will merge this then:) |
Accordingly to the discussion #1773
limsResultDatawas removed from the backend signals' messages in 6af4e5dThis PR removes it and related features from the frontend.
limsResultDatais not stored in global state, and there is no option ofView resultsandView results in ISPYBany more