Moved all diffractometer routes in /routes to the diffractometer adapter #1847
Conversation
marcus-oscarsson
force-pushed
the
mo-diff-route-cleanup
branch
4 times, most recently
from
aea916a to
d957052
Compare
| await sendExecuteCommand('diffractometer', 'diffractometer', 'set_phase', { | ||
| phase, | ||
| }); | ||
| dispatch(setCurrentPhase(phase)); |
There was a problem hiding this comment.
Oh just to double check: does sendExecuteCommand resolve to a value — i.e. does the server respond with the updated phase value? If so, it would be best to use that value to update the Redux store.
Or maybe the updated value is sent soon after via a signal and the dispatch is not needed?
There was a problem hiding this comment.
Oh, good point. I overlooked the dispatch. sendExecuteCommand can return a value, in the case of set_phase its done via an event (because its a action that can take some time). We should perhaps when you mention it distinguish between the two types, i.e have a sendAsync variant or something ?
There was a problem hiding this comment.
At the moment, I think I will keep things as it is. But Ill think about a pattern or how to better handle/specify values updated by events
There was a problem hiding this comment.
We should perhaps when you mention it distinguish between the two types, i.e have a sendAsync variant or something ?
I see, thanks for the clarification! Yeah in that case it might be good, eventually, to have two distinct endpoints for predictability. 💯
marcus-oscarsson
force-pushed
the
mo-diff-route-cleanup
branch
from
d957052 to
ef13ab4
Compare
Moved all the remaining "diffractometer routes" in
/routesto theDiffractometerAdapter