remove N814 exceptions #1853
Merged
remove N814 exceptions #1853
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
walesch-yan
force-pushed
the
yw-remove-N814-exceptions
branch
from
225439f to
bacb97d
Compare
|
We could do the same for MXCuBE-Core. |
Yes, to stay consistent with the configurations across both repos I agree |
marcus-oscarsson
force-pushed
the
yw-remove-N814-exceptions
branch
from
bacb97d to
a156a0d
Compare
Here: mxcube/mxcubecore#1363. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the
N814rule exceptions fromruff.toml. The rule was ignored in many files since it triggers onSince #1849,
HWRis whitelisted, hence the file-wide exceptions are not needed anymore