clean-up beamline actions #1862
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
walesch-yan
commented
Sep 4, 2025
| * msg: arbitray message describing current state | ||
| */ | ||
| export const INITIAL_STATE = { | ||
| const INITIAL_STATE = { |
There was a problem hiding this comment.
also removed this unecessary export
mockoocy
approved these changes
Sep 5, 2025
marcus-oscarsson
force-pushed
the
yw-cleanup-beamline-actions
branch
from
047c913 to
0c094d1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR cleans up the beamline actions (as in redux actions). In principle, three things have been changed/removed:
actions/beamline.jscontained a list of action types as variables that should be supported, in practice only three were used, so removed them.STATEenum used in the reducer that was missing possible states for the hwos, hence completely replaced the calls with the states defined inconstants.js