Remove unused NewSampleIsaraView #1876
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, looks good ! |
|
Well done ! |
|
Also, thanks for the heads up. Its better to remove this component for now and then eventually re-introduce something similair if needed in the future, seeing that its not been maintained for some time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the discussion in #1819 (comment). The component
NewSampleIsaraViewseems to be deprecated and no longer used in MAXIV.However, i am not sure if it's still being used by other facilities, so i opened this to expand the discussion and, perhaps, move towards even removing this Cats90 hwo as it can be deprecated as well.