Skip to content

Conversation

matyson
Copy link
Contributor

@matyson matyson commented Sep 16, 2025

When not explicitly setting num_snapshots in collect.yaml file and loading this property in MYCollect(for example) hwo the number_of_snapshots on the frontend may be different than the one set on the backend due to the fact that we are keeping two sources of truth for the same data ( in the reducer store and in the HWO) and we are also keeping at least three aliases for the same thing, e.g., take_snapshots, num_snapshots and number_of_snapshots.

TBH, im not happy with this solution as it feels hacky, but i didn't felt comfortable with diving into AbstractCollect and AbstractMultiCollect objects and trying to unify these properties. Im willing to try it, though, just need some guidance (in particular with the data collection parameters which its use isn't clear for me).

@marcus-oscarsson
Copy link
Member

Well done ! I think you did well to not dig too deep into this issue immediately. This code is very convoluted and is partly used by the workflow engine so its not that easy to debug. We will try to help out with cleaning this one up, we would also like to make this much simpler.

I think your fix is fine for the time being.

@marcus-oscarsson marcus-oscarsson merged commit 1e73768 into mxcube:develop Sep 17, 2025
12 checks passed
@matyson matyson deleted the sync-numsnapshots branch September 17, 2025 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants