Sync number of snapshots between HWR and frontend on startup #1879
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When not explicitly setting
num_snapshots
incollect.yaml
file and loading this property inMYCollect
(for example) hwo thenumber_of_snapshots
on the frontend may be different than the one set on the backend due to the fact that we are keeping two sources of truth for the same data ( in the reducer store and in the HWO) and we are also keeping at least three aliases for the same thing, e.g.,take_snapshots
,num_snapshots
andnumber_of_snapshots
.TBH, im not happy with this solution as it feels hacky, but i didn't felt comfortable with diving into
AbstractCollect
andAbstractMultiCollect
objects and trying to unify these properties. Im willing to try it, though, just need some guidance (in particular with the data collection parameters which its use isn't clear for me).