Validate beamline attributes and handle server errors #1880
+68
−40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axelboc
commented
Sep 17, 2025
| )} | ||
| </ButtonToolbar> | ||
| <Form noValidate onSubmit={makeOnSubmit(handleSubmit)}> | ||
| <div className="d-flex"> |
There was a problem hiding this comment.
Adding a div here so the error message appears underneath the field and button. The relevant changes can be seen by hiding whitespace changes in GitHub.
|
Wouhha, awesome ! |
marcus-oscarsson
force-pushed
the
ab-attribute-validation
branch
from
deb2c6b to
1d507ff
Compare
|
|
Thanks again, very nice ! |
|
No worries, yeah 400 with a clear error message about the limits or whatever else goes wrong. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1842
The form is now managed with
react-hook-form, with the following validation rules:limitsFor UX, the errors are of course not shown until the form becomes "dirty", that is until the user first tries to submit a value. After that, the validation happens as the user types — this way, they can see quickly if they go over/under the limits.
Screencast.from.2025-09-17.11-44-56.webm
If a server error occurs during submission, the form shows "Unable to set value". In the recording below, I disabled the max validation to demonstrate.
Screencast.from.2025-09-17.11-33-23.webm