perf: inline functions of broker_bootstrap.rs

[Parizval]

Which Issue(s) This PR Fixes(Closes)

Fixes #3938

Brief Description

Adding inline to functions of broker_bootstrap.rs

How Did You Test This Change?

Summary by CodeRabbit

• Refactor

  • Applied compiler inlining hints to internal startup routines to streamline execution. No changes to behavior, configuration, or interfaces. Stability and compatibility remain unchanged.

• Performance

  • Minor optimization that may slightly reduce overhead during broker initialization and startup in certain builds. No measurable impact expected for most users.

[coderabbitai]

Walkthrough

Added #[inline] attributes to two private methods of BrokerBootstrap (initialize and start) in rocketmq-broker/src/broker_bootstrap.rs. Method signatures and bodies are unchanged; they still await calls to broker_runtime.initialize() and broker_runtime.start().

Changes

Cohort / File(s)	Summary
Inlining attributes rocketmq-broker/src/broker_bootstrap.rs	Added #[inline] to BrokerBootstrap::initialize and BrokerBootstrap::start. No logic, signature, or control-flow changes.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

Hop, hop—tiny tags inline,
Two methods now are swift and fine.
No new paths, no logic spun,
Just a nudge to help them run.
Carrot-shaped commits aligned—
Broker boots, the rabbit’s shined! 🥕✨

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 66.67% which is insufficient. The required threshold is 80.00%.	You can run @coderabbitai generate docstrings to improve docstring coverage.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check	✅ Passed	The title "perf: inline functions of broker_bootstrap.rs" concisely and accurately describes the primary change in the patch—adding #[inline] annotations to functions in broker_bootstrap.rs—without irrelevant detail or noise. It is short, specific to the affected file, and useful for teammates scanning history.
Linked Issues Check	✅ Passed	Linked issue [#3938] requested adding #[inline] to BrokerBootstrap::initialize and BrokerBootstrap::start, and the patch shows those inline attributes were added to the two methods in broker_bootstrap.rs with no signature or behavioral changes, so the code-level objectives from the linked issue are met. There are no other coding requirements in the issue that remain unaddressed.
Out of Scope Changes Check	✅ Passed	The provided diff and summary indicate only the addition of #[inline] attributes in broker_bootstrap.rs and explicitly state no exported/public declarations were altered, so there are no detected out-of-scope or unrelated code changes introduced by this PR. The change appears localized to the intended enhancement.

✨ Finishing touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment

Tip

👮 Agentic pre-merge checks are now available in preview!

Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.

• Built-in checks – Quickly apply ready-made checks to enforce title conventions, require pull request descriptions that follow templates, validate linked issues for compliance, and more.
• Custom agentic checks – Define your own rules using CodeRabbit’s advanced agentic capabilities to enforce organization-specific policies and workflows. For example, you can instruct CodeRabbit’s agent to verify that API documentation is updated whenever API schema files are modified in a PR. Note: Upto 5 custom checks are currently allowed during the preview period. Pricing for this feature will be announced in a few weeks.

Please see the documentation for more information.

Example:

reviews:
  pre_merge_checks:
    custom_checks:
      - name: "Undocumented Breaking Changes"
        mode: "warning"
        instructions: |
          Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).

Please share your feedback with us on this Discord post.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[rocketmq-rust-bot]

🔊@Parizval 🚀Thanks for your contribution🎉！

💡CodeRabbit(AI) will review your code first🔥！

Note

🚨The code review suggestions from CodeRabbit are to be used as a reference only, and the PR submitter can decide whether to make changes based on their own judgment. Ultimately, the project management personnel will conduct the final code review💥.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 26.51%. Comparing base (a4569f5) to head (a63adc3).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #4042   +/-   ##
=======================================
  Coverage   26.51%   26.51%           
=======================================
  Files         568      568           
  Lines       80867    80867           
=======================================
  Hits        21440    21440           
  Misses      59427    59427           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (4)

rocketmq-broker/src/broker_bootstrap.rs (4)

69-76: Unnecessary #[inline] on Builder::new; out of scope of linked issue.

Builder constructors aren’t in hot paths and this wasn’t requested by #3938. Suggest reverting to reduce attribute noise.

-    #[inline]
     pub fn new() -> Self {

---

77-81: Drop #[inline] on set_broker_config.

Tiny setter; no evidence of benefit. Keep code lean unless profiling says otherwise.

-    #[inline]
     pub fn set_broker_config(mut self, broker_config: BrokerConfig) -> Self {

---

82-86: Drop #[inline] on set_message_store_config.

Same rationale as above.

-    #[inline]
     pub fn set_message_store_config(mut self, message_store_config: MessageStoreConfig) -> Self {

---

92-101: Drop #[inline] on build.

Not performance-critical; removing keeps attributes focused on the intended targets.

-    #[inline]
     pub fn build(self) -> BrokerBootstrap {

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a4569f5 and a63adc3.

📒 Files selected for processing (1)

• rocketmq-broker/src/broker_bootstrap.rs (1 hunks)

🧰 Additional context used

🧬 Code graph analysis (1)

rocketmq-broker/src/broker_bootstrap.rs (1)

rocketmq-broker/src/broker_runtime.rs (1)

• initialize (444-456)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (9)

• GitHub Check: build (windows-latest, nightly)
• GitHub Check: build (macos-latest, nightly)
• GitHub Check: test
• GitHub Check: build (ubuntu-latest, stable)
• GitHub Check: build (windows-latest, stable)
• GitHub Check: build (macos-latest, stable)
• GitHub Check: build
• GitHub Check: build (ubuntu-latest, nightly)
• GitHub Check: auto-approve

🔇 Additional comments (2)

rocketmq-broker/src/broker_bootstrap.rs (2)

42-45: OK to inline; fulfills issue intent. Note: async #[inline] usually has negligible effect.

For async fns, #[inline] only hints inlining of the small future-constructor stub; the state machine isn’t inlined. Harmless, but unlikely to yield perf wins. If this was for measurable gains, please share a before/after bench.

---

46-49: Same here: meets objective; practical impact likely minimal.

Inlining the async start() wrapper is fine but probably not performance-relevant. Consider keeping only if you’ve profiled.

[rocketmq-rust-bot]

LGTM

[mxsm]

LGTM