Skip to content

Conversation

Parizval
Copy link
Contributor

@Parizval Parizval commented Sep 19, 2025

Which Issue(s) This PR Fixes(Closes)

Fixes #3945
Fix #3832

Brief Description

How Did You Test This Change?

@rocketmq-rust-bot
Copy link
Collaborator

🔊@Parizval 🚀Thanks for your contribution🎉!

💡CodeRabbit(AI) will review your code first🔥!

Note

🚨The code review suggestions from CodeRabbit are to be used as a reference only, and the PR submitter can decide whether to make changes based on their own judgment. Ultimately, the project management personnel will conduct the final code review💥.

Copy link

codecov bot commented Sep 19, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 26.48%. Comparing base (d779ced) to head (a0b9fe0).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4066      +/-   ##
==========================================
+ Coverage   26.47%   26.48%   +0.01%     
==========================================
  Files         574      574              
  Lines       81191    81195       +4     
==========================================
+ Hits        21496    21507      +11     
+ Misses      59695    59688       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Collaborator

@rocketmq-rust-bot rocketmq-rust-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mxsm mxsm merged commit b3f26fe into mxsm:main Sep 19, 2025
16 of 27 checks passed
@rocketmq-rust-bot rocketmq-rust-bot added approved PR has approved and removed ready to review waiting-review waiting review this PR labels Sep 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Enhancement⚡️] Remove unimplemented controller mode log message from broker_runtime [Unit Test🧪]Add test case for ServerConfig

4 participants