-
Notifications
You must be signed in to change notification settings - Fork 174
[ISSUE #3917]🐛Update GetAllSubscriptionGroupConfig to GetAllMessageRequestMode #4071
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…geRequestMode in broker_outer_api
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes a bug where the wrong request code was being used in the get_all_message_request_mode
method. The method was incorrectly using GetAllSubscriptionGroupConfig
instead of the correct GetAllMessageRequestMode
request code.
- Updates the request code from
GetAllSubscriptionGroupConfig
toGetAllMessageRequestMode
in the broker outer API
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
🔊@WaterWhisperer 🚀Thanks for your contribution🎉! 💡CodeRabbit(AI) will review your code first🔥! Note 🚨The code review suggestions from CodeRabbit are to be used as a reference only, and the PR submitter can decide whether to make changes based on their own judgment. Ultimately, the project management personnel will conduct the final code review💥. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4071 +/- ##
=======================================
Coverage 26.49% 26.49%
=======================================
Files 574 574
Lines 81187 81187
=======================================
Hits 21507 21507
Misses 59680 59680 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Which Issue(s) This PR Fixes(Closes)
Fixes #3917
Brief Description
Update GetAllSubscriptionGroupConfig to GetAllMessageRequestMode
How Did You Test This Change?
Ran cargo clippy and cargo test following the Contribute Guide, after that there were some warnings that had nothing to do with this change. I'm not sure if I should fix 'em.