Skip to content

Conversation

WaterWhisperer
Copy link
Contributor

Which Issue(s) This PR Fixes(Closes)

Fixes #3917

Brief Description

Update GetAllSubscriptionGroupConfig to GetAllMessageRequestMode

How Did You Test This Change?

Ran cargo clippy and cargo test following the Contribute Guide, after that there were some warnings that had nothing to do with this change. I'm not sure if I should fix 'em.

@Copilot Copilot AI review requested due to automatic review settings September 20, 2025 05:15
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a bug where the wrong request code was being used in the get_all_message_request_mode method. The method was incorrectly using GetAllSubscriptionGroupConfig instead of the correct GetAllMessageRequestMode request code.

  • Updates the request code from GetAllSubscriptionGroupConfig to GetAllMessageRequestMode in the broker outer API

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@rocketmq-rust-bot
Copy link
Collaborator

🔊@WaterWhisperer 🚀Thanks for your contribution🎉!

💡CodeRabbit(AI) will review your code first🔥!

Note

🚨The code review suggestions from CodeRabbit are to be used as a reference only, and the PR submitter can decide whether to make changes based on their own judgment. Ultimately, the project management personnel will conduct the final code review💥.

Copy link

codecov bot commented Sep 20, 2025

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 26.49%. Comparing base (9c445c2) to head (dd2876c).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
rocketmq-broker/src/out_api/broker_outer_api.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4071   +/-   ##
=======================================
  Coverage   26.49%   26.49%           
=======================================
  Files         574      574           
  Lines       81187    81187           
=======================================
  Hits        21507    21507           
  Misses      59680    59680           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Collaborator

@rocketmq-rust-bot rocketmq-rust-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Owner

@mxsm mxsm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mxsm mxsm merged commit f706731 into mxsm:main Sep 20, 2025
14 of 24 checks passed
@rocketmq-rust-bot rocketmq-rust-bot added approved PR has approved and removed ready to review waiting-review waiting review this PR labels Sep 20, 2025
@WaterWhisperer WaterWhisperer deleted the bug-issueNo3917 branch September 20, 2025 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AI review first Ai review pr first approved PR has approved auto merge bug🐛 Something isn't working Difficulty level/Easy Easy ISSUE

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug🐛] Update GetAllSubscriptionGroupConfig to GetAllMessageRequestMode in broker_outer_api

4 participants