-
Notifications
You must be signed in to change notification settings - Fork 175
[ISSUE #3825]🐛Incorrect brokerRole in broker-simple-slave.toml #4085
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes a configuration error in the broker-simple-slave.toml file where the brokerRole was incorrectly set to "ASYNC_MASTER" instead of "SLAVE".
- Corrects the brokerRole value from "ASYNC_MASTER" to "SLAVE" in the slave configuration file
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
🔊@WaterWhisperer 🚀Thanks for your contribution🎉! 💡CodeRabbit(AI) will review your code first🔥! Note 🚨The code review suggestions from CodeRabbit are to be used as a reference only, and the PR submitter can decide whether to make changes based on their own judgment. Ultimately, the project management personnel will conduct the final code review💥. |
Hi @mxsm , thank you for review! I'm really happy to make a contribution. I have a quick question for future contributions. I noticed some pre-existing warnings when I ran Thanks for your guidance! |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4085 +/- ##
=======================================
Coverage 26.48% 26.48%
=======================================
Files 574 574
Lines 81205 81205
=======================================
Hits 21507 21507
Misses 59698 59698 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Which Issue(s) This PR Fixes(Closes)
Fixes #3825
Brief Description
Incorrect brokerRole in broker-simple-slave.toml (should be SLAVE)
How Did You Test This Change?
Start broker using the corrected sample and verify it registers as a slave