Skip to content

Conversation

WaterWhisperer
Copy link
Contributor

Which Issue(s) This PR Fixes(Closes)

Fixes #3825

Brief Description

Incorrect brokerRole in broker-simple-slave.toml (should be SLAVE)

How Did You Test This Change?

Start broker using the corrected sample and verify it registers as a slave

@Copilot Copilot AI review requested due to automatic review settings September 21, 2025 06:08
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a configuration error in the broker-simple-slave.toml file where the brokerRole was incorrectly set to "ASYNC_MASTER" instead of "SLAVE".

  • Corrects the brokerRole value from "ASYNC_MASTER" to "SLAVE" in the slave configuration file

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@rocketmq-rust-bot
Copy link
Collaborator

🔊@WaterWhisperer 🚀Thanks for your contribution🎉!

💡CodeRabbit(AI) will review your code first🔥!

Note

🚨The code review suggestions from CodeRabbit are to be used as a reference only, and the PR submitter can decide whether to make changes based on their own judgment. Ultimately, the project management personnel will conduct the final code review💥.

@WaterWhisperer
Copy link
Contributor Author

Hi @mxsm , thank you for review! I'm really happy to make a contribution.

I have a quick question for future contributions. I noticed some pre-existing warnings when I ran cargo clippy and cargo test. To be a better contributor, I was wondering what the project's policy is on these? Should I fix unrelated warnings if I see them in a future PR, or is it better to open a separate issue for them? I'd be happy to open a new PR to address those warnings if that would be helpful for the project.

Thanks for your guidance!

Copy link

codecov bot commented Sep 21, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 26.48%. Comparing base (f822e9a) to head (7d8a1ef).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4085   +/-   ##
=======================================
  Coverage   26.48%   26.48%           
=======================================
  Files         574      574           
  Lines       81205    81205           
=======================================
  Hits        21507    21507           
  Misses      59698    59698           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Collaborator

@rocketmq-rust-bot rocketmq-rust-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Owner

@mxsm mxsm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mxsm mxsm merged commit 000dd49 into mxsm:main Sep 21, 2025
15 of 24 checks passed
@rocketmq-rust-bot rocketmq-rust-bot added approved PR has approved and removed ready to review waiting-review waiting review this PR labels Sep 21, 2025
@WaterWhisperer WaterWhisperer deleted the bug-issueNo3825 branch September 21, 2025 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AI review first Ai review pr first approved PR has approved auto merge bug🐛 Something isn't working Difficulty level/Easy Easy ISSUE

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug🐛] Incorrect brokerRole in broker-simple-slave.toml (should be SLAVE)

4 participants