Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions rocketmq-broker/benches/syncunsafecell_mut.rs
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,12 @@ pub struct Test {
pub b: parking_lot::Mutex<HashSet<String>>,
}

impl Default for Test {
fn default() -> Self {
Self::new()
}
}

impl Test {
pub fn new() -> Self {
Test {
Expand Down
9 changes: 0 additions & 9 deletions rocketmq-broker/src/metrics/broker_metrics_constant.rs
Original file line number Diff line number Diff line change
Expand Up @@ -340,15 +340,6 @@ impl MetricCategory {
mod tests {
use super::*;

#[test]
fn test_constants_not_empty() {
assert!(!BrokerMetricsConstant::OPEN_TELEMETRY_METER_NAME.is_empty());
assert!(!BrokerMetricsConstant::GAUGE_PROCESSOR_WATERMARK.is_empty());
assert!(!BrokerMetricsConstant::COUNTER_MESSAGES_IN_TOTAL.is_empty());
assert!(!BrokerMetricsConstant::HISTOGRAM_MESSAGE_SIZE.is_empty());
assert!(!BrokerMetricsConstant::LABEL_CLUSTER_NAME.is_empty());
}

#[test]
fn test_organized_modules() {
// Test organized gauge constants
Expand Down
8 changes: 0 additions & 8 deletions rocketmq-broker/src/metrics/pop_metrics_constant.rs
Original file line number Diff line number Diff line change
Expand Up @@ -331,14 +331,6 @@ impl PopMetricLabels {
mod tests {
use super::*;

#[test]
fn test_constants_not_empty() {
assert!(!PopMetricsConstant::HISTOGRAM_POP_BUFFER_SCAN_TIME_CONSUME.is_empty());
assert!(!PopMetricsConstant::COUNTER_POP_REVIVE_IN_MESSAGE_TOTAL.is_empty());
assert!(!PopMetricsConstant::GAUGE_POP_REVIVE_LAG.is_empty());
assert!(!PopMetricsConstant::LABEL_REVIVE_MESSAGE_TYPE.is_empty());
}

#[test]
fn test_organized_modules() {
// Test organized metric constants
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,12 @@ pub struct MyMessageListener {
consume_times: Arc<AtomicI64>,
}

impl Default for MyMessageListener {
fn default() -> Self {
Self::new()
}
}

impl MyMessageListener {
pub fn new() -> Self {
Self {
Expand Down
18 changes: 12 additions & 6 deletions rocketmq-namesrv/src/processor/default_request_processor.rs
Original file line number Diff line number Diff line change
Expand Up @@ -773,8 +773,10 @@ mod tests {
let body = vec![/* some valid data */];
let crc32 = CRC32Utils::crc32(&body);
let request = RemotingCommand::new_request(0, body);
let mut request_header = RegisterBrokerRequestHeader::default();
request_header.body_crc32 = crc32;
let request_header = RegisterBrokerRequestHeader {
body_crc32: crc32,
..Default::default()
};
let result = check_sum_crc32(&request, &request_header);
assert!(result);
}
Expand All @@ -783,8 +785,10 @@ mod tests {
fn check_sum_crc32_invalid_crc() {
let body = vec![/* some valid data */];
let request = RemotingCommand::new_request(0, body);
let mut request_header = RegisterBrokerRequestHeader::default();
request_header.body_crc32 = 12345; // some invalid crc32
let request_header = RegisterBrokerRequestHeader {
body_crc32: 12345, // some invalid crc32
..Default::default()
};
let result = check_sum_crc32(&request, &request_header);
assert!(!result);
}
Expand All @@ -793,8 +797,10 @@ mod tests {
fn check_sum_crc32_zero_crc() {
let body = vec![/* some valid data */];
let request = RemotingCommand::new_request(0, body);
let mut request_header = RegisterBrokerRequestHeader::default();
request_header.body_crc32 = 0;
let request_header = RegisterBrokerRequestHeader {
body_crc32: 0,
..Default::default()
};
let result = check_sum_crc32(&request, &request_header);
assert!(result);
}
Expand Down
14 changes: 9 additions & 5 deletions rocketmq-store/src/ha/flow_monitor.rs
Original file line number Diff line number Diff line change
Expand Up @@ -168,18 +168,22 @@ mod tests {

#[test]
fn can_transfer_max_byte_num_returns_correct_value_when_flow_control_enabled() {
let mut config = MessageStoreConfig::default();
config.ha_flow_control_enable = true;
config.max_ha_transfer_byte_in_second = 200;
let config = MessageStoreConfig {
ha_flow_control_enable: true,
max_ha_transfer_byte_in_second: 200,
..Default::default()
};
let inner = FlowMonitorInner::new(Arc::new(config));
inner.add_byte_count_transferred(150);
assert_eq!(inner.can_transfer_max_byte_num(), 50);
}

#[test]
fn can_transfer_max_byte_num_returns_max_value_when_flow_control_disabled() {
let mut config = MessageStoreConfig::default();
config.ha_flow_control_enable = false;
let config = MessageStoreConfig {
ha_flow_control_enable: false,
..Default::default()
};
let inner = FlowMonitorInner::new(Arc::new(config));
assert_eq!(inner.can_transfer_max_byte_num(), i32::MAX);
}
Expand Down
2 changes: 1 addition & 1 deletion rocketmq-store/src/message_store.rs
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ pub mod rocksdb_message_store;

pub enum GenericMessageStore {
#[cfg(feature = "local_file_store")]
LocalFileStore(local_file_message_store::LocalFileMessageStore),
LocalFileStore(Box<local_file_message_store::LocalFileMessageStore>),

#[cfg(feature = "rocksdb_store")]
RocksDBStore(rocksdb_message_store::RocksDBMessageStore),
Expand Down
Loading