Merge pull request #130 from effone/skip-glob

effone · web-flow · commit 4dd33084dd92 · 2021-02-13T18:00:42.000+05:30
Skip repeated file scan
diff --git a/upload/inc/plugins/isango.php b/upload/inc/plugins/isango.php
@@ -716,10 +716,12 @@ function isango_gateway_error(string $gateway)
 function isango_config(string $gateway = "", string $mode = "")
 {
 	$path = MYBB_ROOT . 'inc/plugins/isango/%s.ini';
-	$gateways = array();
+	static $gateways = array();
 
-	foreach (glob(sprintf($path, '*')) as $gate) {
-		$gateways[] = strtolower(basename($gate, '.ini'));
+	if (empty($gateways)) {
+		foreach (glob(sprintf($path, '*')) as $gate) {
+			$gateways[] = strtolower(basename($gate, '.ini'));
+		}
 	}
 
 	if (empty($gateway)) {

Original file line number	Diff line number	Diff line change
`@@ -716,10 +716,12 @@ function isango_gateway_error(string $gateway)`
`716`	`716`	`function isango_config(string $gateway = "", string $mode = "")`
`717`	`717`	`{`
`718`	`718`	`$path = MYBB_ROOT . 'inc/plugins/isango/%s.ini';`
`719`		`- $gateways = array();`
	`719`	`+ static $gateways = array();`
`720`	`720`
`721`		`- foreach (glob(sprintf($path, '*')) as $gate) {`
`722`		`- $gateways[] = strtolower(basename($gate, '.ini'));`
	`721`	`+ if (empty($gateways)) {`
	`722`	`+ foreach (glob(sprintf($path, '*')) as $gate) {`
	`723`	`+ $gateways[] = strtolower(basename($gate, '.ini'));`
	`724`	`+ }`
`723`	`725`	`}`
`724`	`726`
`725`	`727`	`if (empty($gateway)) {`