Skip to content

Conversation

Sunrongguo2008
Copy link

@Sunrongguo2008 Sunrongguo2008 commented Sep 3, 2025

Description

This pull request replaces the dependency “rofi-wayland” with “rofi” since “rofi” now has native Wayland support. Additionally, “rofi” provides better compatibility with input method frameworks such as fcitx, making it a more versatile choice compared to “rofi-wayland”.

Changes

  • Improved
  • Bug Fixes
  • Feature
  • Documentation
  • Other

Context

This change is necessary because “rofi” has gained native Wayland support, making “rofi-wayland” redundant. Moreover, “rofi” works better with IME frameworks (like fcitx), which solves compatibility issues encountered with “rofi-wayland”.

How Has This Been Tested?

  • Tested on Arch Linux/Based Distro.
  • Tested on Fedora Linux/Based Distro.
  • Tested on openSuse.

Checklist

Please ensure your pull request meets the following requirements:

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my code.
  • I have commented on my code, particularly in hard-to-understand areas.
  • My changes do not introduce new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have made corresponding changes to the documentation
  • New and existing unit tests pass locally with my changes.

Screenshots

Related Issues

Additional Notes

No further notes.

@mylinuxforwork mylinuxforwork self-assigned this Sep 3, 2025
@mylinuxforwork mylinuxforwork added this to the 2.9.9.2 milestone Sep 3, 2025
@mylinuxforwork
Copy link
Owner

Thank you for the PR. I will test it.

@Sunrongguo2008 Sunrongguo2008 changed the title Replace dependency “rofi-wayland” with “rofi” for better Wayland and IME support Replace dependency “rofi-wayland” with “rofi” for better IME support Sep 4, 2025
@mylinuxforwork
Copy link
Owner

Hi. When I install rofi with sudo pacman -S rofi, I still don't get rofi 2.0.0 with full wayland support.
Is it the same on your side?

@Sunrongguo2008
Copy link
Author

The latest version I can get is 1.7.9.1, maybe we should wait for the repository to be updated, or compile and install it?
Another point to note is that there is a conflict between rofi and rofi-wayland; perhaps the installation script should first uninstall rofi-wayland before installing rofi.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants