Improved Error messages on board list and fixed python command issue

Author: rijesha

README.md

@@ -41,7 +41,6 @@ In order for this application to work correctly the zephyr require build tools n
 
 See the [Install Dependecies Section of the Zephyr Getting Started Guide](https://docs.zephyrproject.org/latest/develop/getting_started/index.html#install-dependencies)
 
-For ubuntu please also install python3-venv by ```sudo apt install python3-venv```
 
 ## Testing
 

package-lock.json

@@ -2,7 +2,7 @@
   "name": "zephyr-ide",
   "displayName": "Zephyr IDE",
   "description": "A VS Code extension that streamlines setup, build, flashing, and debugging of Zephyr Projects",
-  "version": "1.10.3",
+  "version": "1.10.6",
   "license": "Apache-2.0",
   "publisher": "mylonics",
   "icon": "media/logo.png",

package.json

@@ -74,25 +74,31 @@ async function getBoardlistWest(setupState: SetupState, folder: vscode.Uri | und
     boardRootString = " --board-root " + path.dirname(folder.fsPath);
   }
 
-  let prevError: any;
-  if (setupState.zephyrVersion === undefined) { return; }
+  if (setupState.zephyrVersion === undefined) {
+    console.log("Returning because zephyrVersion is not set");
+    return;
+  }
   let res;
   let has_qualifiers = false;
   let has_revisions = false;
+
   if (isVersionNumberGreater(setupState.zephyrVersion, 4, 1, 0)) {
-    res = await executeShellCommandInPythonEnv("west boards -f '{name};{dir};{qualifiers};{revisions};{revision_default}'" + boardRootString, setupState.setupPath, setupState, false);
+    console.log("Getting board list greater than v4.1.0");
+    res = await executeShellCommandInPythonEnv('west boards -f "{name};{dir};{qualifiers};{revisions};{revision_default}" ' + boardRootString, setupState.setupPath, setupState, false);
     has_qualifiers = true;
     has_revisions = true;
   } else if (isVersionNumberGreaterEqual(setupState.zephyrVersion, 3, 7, 0)) {
-    res = await executeShellCommandInPythonEnv("west boards -f '{name};{dir};{qualifiers}'" + boardRootString, setupState.setupPath, setupState, false);
+    console.log("Getting board v3.7.0 and greater");
+    res = await executeShellCommandInPythonEnv('west boards -f "{name};{dir};{qualifiers}" ' + boardRootString, setupState.setupPath, setupState, false);
     has_qualifiers = true;
   } else {
-    res = await executeShellCommandInPythonEnv("west boards -f '{name};{dir}'" + boardRootString, setupState.setupPath, setupState, false);
+    console.log("Getting board legacy");
+    res = await executeShellCommandInPythonEnv('west boards -f "{name};{dir}" ' + boardRootString, setupState.setupPath, setupState, false);
   }
 
-  if (!res.stdout) {
-    output.append(prevError);
-    output.append(res.stderr);
+  if (!res.stdout || res.stdout === "") {
+    console.log("Board list error");
+    console.log(res.stderr);
     vscode.window.showErrorMessage("Failed to run west boards command. See Zephyr IDE Output for error message");
     return;
   }

src/project_utilities/build_selector.ts

@@ -246,7 +246,7 @@ export async function setupWestEnvironment(context: vscode.ExtensionContext, wsC
       }
 
       // Install `west`
-      let res = await executeShellCommandInPythonEnv(`python -m pip install west`, wsConfig.activeSetupState.setupPath, wsConfig.activeSetupState, true);
+      let res = await executeShellCommandInPythonEnv(`pip install west`, wsConfig.activeSetupState.setupPath, wsConfig.activeSetupState, true);
       if (res.stdout) {
         output.append(res.stdout);
         output.appendLine("[SETUP] west installed");

src/setup_utilities/west-operations.ts

@@ -166,7 +166,8 @@ suite("Workflow Integration Test Suite", () => {
                         );
                     } else if (currentStep === "build-config") {
                         const firstItemLabel = (items[0]?.label || "").toLowerCase();
-                        if (firstItemLabel.includes("zephyr directory")) {
+                        if (firstItemLabel.includes("zephyr directory") || items.some((item: any) => item.label?.toLowerCase().includes("zephyr directory"))) {
+                            console.log('   → Build Config: Selecting Zephyr Directory Only option');
                             return (
                                 items.find((item: any) =>
                                     item.label?.toLowerCase().includes("zephyr directory")
@@ -222,19 +223,26 @@ suite("Workflow Integration Test Suite", () => {
                     hide: () => { },
                     dispose: () => { },
                     show: () => {
-                        setTimeout(() => {
-                            const selectedItem = getSelection(mockQuickPick.items);
-                            if (selectedItem) {
-                                mockQuickPick.selectedItems = [selectedItem];
-                                mockQuickPick.activeItems = [selectedItem];
-                                if (mockQuickPick._onDidChangeSelectionCallback) {
-                                    mockQuickPick._onDidChangeSelectionCallback([selectedItem]);
+                        const checkAndSelect = () => {
+                            if (mockQuickPick.items && mockQuickPick.items.length > 0) {
+                                const selectedItem = getSelection(mockQuickPick.items);
+                                if (selectedItem) {
+                                    console.log(`   → QuickPick: Selected "${selectedItem.label || selectedItem}" from ${mockQuickPick.items.length} items`);
+                                    mockQuickPick.selectedItems = [selectedItem];
+                                    mockQuickPick.activeItems = [selectedItem];
+                                    if (mockQuickPick._onDidChangeSelectionCallback) {
+                                        mockQuickPick._onDidChangeSelectionCallback([selectedItem]);
+                                    }
                                 }
+                                if (mockQuickPick._onDidAcceptCallback) {
+                                    mockQuickPick._onDidAcceptCallback();
+                                }
+                            } else {
+                                // Retry if items not populated yet
+                                setTimeout(checkAndSelect, 5000);
                             }
-                            if (mockQuickPick._onDidAcceptCallback) {
-                                mockQuickPick._onDidAcceptCallback();
-                            }
-                        }, 8000);
+                        };
+                        setTimeout(checkAndSelect, 2000);
                     },
                     onDidTriggerButton: () => ({ dispose: () => { } }),
                     onDidChangeSelection: (callback: any) => {
@@ -292,7 +300,7 @@ suite("Workflow Integration Test Suite", () => {
                             if (mockInputBox._onDidAcceptCallback) {
                                 mockInputBox._onDidAcceptCallback();
                             }
-                        }, 8000);
+                        }, 30000);
                     },
                     onDidAccept: (callback: any) => {
                         mockInputBox._onDidAcceptCallback = callback;
@@ -445,6 +453,15 @@ suite("Workflow Integration Test Suite", () => {
             globalQuickPickCallCount = 0;
             globalInputBoxCallCount = 0;
             currentStep = "build-config";
+            
+            // Check if west is available before attempting build config
+            const ext = vscode.extensions.getExtension("mylonics.zephyr-ide");
+            const wsConfig = ext?.exports?.getWorkspaceConfig();
+            if (!wsConfig?.initialSetupComplete) {
+                console.log("⚠️ Setup not complete, retrying in 10 seconds...");
+                await new Promise((resolve) => setTimeout(resolve, 10000));
+            }
+            
             result = await vscode.commands.executeCommand("zephyr-ide.add-build");
             assert.ok(result, "Build configuration should succeed");
 

src/test/workflow-integration.test.ts

@@ -70,6 +70,10 @@ export function getPythonVenvBinaryFolder(setupState: SetupState) {
   return '';
 }
 
+function generatePythonModuleCmdString(setupState: SetupState, cmd: string) {
+  return path.join(getPythonVenvBinaryFolder(setupState), "python -m ", cmd);
+}
+
 export async function getRootPathFs(first = false) {
   let rootPath = await getRootPath(first);
   if (rootPath && rootPath.fsPath) {
@@ -169,9 +173,9 @@ async function executeTask(task: vscode.Task) {
 export async function executeTaskHelperInPythonEnv(setupState: SetupState | undefined, taskName: string, cmd: string, cwd: string | undefined) {
   if (setupState && isMacOS()) {
     let newCmd = path.join(getPythonVenvBinaryFolder(setupState), cmd);
-    return executeTaskHelper(taskName, newCmd, cwd);
+    return await executeTaskHelper(taskName, newCmd, cwd);
   } else {
-    return executeTaskHelper(taskName, cmd, cwd);
+    return await executeTaskHelper(taskName, cmd, cwd);
   }
 }
 
@@ -197,7 +201,8 @@ export async function executeTaskHelper(taskName: string, cmd: string, cwd: stri
 }
 
 export async function executeShellCommandInPythonEnv(cmd: string, cwd: string, setupState: SetupState, display_error = true) {
-  let newCmd = path.join(getPythonVenvBinaryFolder(setupState), cmd);
+  let newCmd = generatePythonModuleCmdString(setupState, cmd);
+  console.log("Running new python command", JSON.stringify(newCmd));
   return executeShellCommand(newCmd, cwd, display_error);
 };
 
@@ -212,6 +217,7 @@ export async function executeShellCommand(cmd: string, cwd: string, display_erro
       if (display_error) {
         output.append(reason);
       }
+      console.log(JSON.stringify(reason));
       return { stdout: undefined, stderr: reason.stderr };
     }
   );