Skip to content

Conversation

Copilot
Copy link
Contributor

@Copilot Copilot AI commented Aug 25, 2025

This PR fixes a critical usability issue where the Zephyr IDE extension was hijacking VS Code's default Ctrl+Shift+P keyboard shortcut for opening the Command Palette.

Problem

When users pressed Ctrl+Shift+P with the Zephyr IDE extension enabled, instead of opening VS Code's Command Palette, the extension would trigger the zephyr-ide.flash command and display the error message "Run Zephyr IDE: West Update first." This made it impossible to access the Command Palette using the standard keyboard shortcut.

Root Cause

The extension defined conflicting keybindings in package.json:

  • zephyr-ide.flash bound to ctrl+shift+p (conflicted with Command Palette)
  • zephyr-ide.build bound to ctrl+shift+B (conflicted with VS Code's build shortcut)

Solution

Completely removed the keybindings section from package.json as suggested by the maintainer. This approach:

  • ✅ Eliminates all keybinding conflicts with VS Code defaults
  • ✅ Allows users to define their own custom keybindings if desired
  • ✅ Maintains full functionality - all commands remain accessible via Command Palette
  • ✅ Follows VS Code extension best practices by not overriding system shortcuts

Commands Affected

The following commands no longer have default keyboard shortcuts but remain fully functional:

  • Zephyr IDE: Build (previously Ctrl+Shift+B)
  • Zephyr IDE: Flash (previously Ctrl+Shift+P)

Users can access these commands via:

  1. Command Palette (Ctrl+Shift+P → type "Zephyr IDE: Build" or "Zephyr IDE: Flash")
  2. Extension UI buttons and menus
  3. Custom keybindings if users choose to define them

Testing

  • ✅ TypeScript compilation passes
  • ✅ ESLint validation passes
  • ✅ Extension builds successfully
  • ✅ All commands remain accessible via Command Palette

Fixes #178.


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Co-authored-by: rijesha <7819200+rijesha@users.noreply.github.com>
@Copilot Copilot AI changed the title [WIP] CTRL+Shift+P (Open Command Palette) is triggering some Zephyr IDE command Remove conflicting keybindings to fix Ctrl+Shift+P Command Palette issue Aug 25, 2025
@Copilot Copilot AI requested a review from rijesha August 25, 2025 15:52
Copilot finished work on behalf of rijesha August 25, 2025 15:52
@rijesha rijesha marked this pull request as ready for review August 25, 2025 15:54
@rijesha rijesha merged commit 6a5fb02 into develop Aug 27, 2025
0 of 3 checks passed
@rijesha rijesha deleted the copilot/fix-178 branch August 27, 2025 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CTRL+Shift+P (Open Command Palette) is triggering some Zephyr IDE command

2 participants