Fix SSH URL validation in Git workspace setup #186
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "West Workspace from Git" and "Zephyr IDE Workspace from Git" setup options were incorrectly rejecting SSH URLs like
git@github.com:user/repo.git
due to overly restrictive validation that required all Git URLs to contain://
.Problem
Users trying to set up workspaces with SSH URLs would encounter validation errors:
The validation logic only accepted URLs with protocols (containing
://
), which excluded the common SSH formatgit@host:path
.Solution
Added comprehensive Git URL validation in
src/utilities/utils.ts
that accepts:https://github.com/user/repo.git
git@github.com:user/repo.git
ssh://git@github.com/user/repo.git
git://github.com/user/repo.git
Updated workspace setup functions in
src/setup_utilities/workspace-setup.ts
to use the new validationImproved user experience with placeholder text showing SSH examples:
"https://github.com/user/repo.git or git@github.com:user/repo.git"
Validation Results
git@github.com:user/repo.git
https://github.com/user/repo.git
ssh://git@github.com/user/repo.git
The fix maintains full backward compatibility while enabling SSH workflow support that works with both
git clone
andwest init
commands.Fixes #185.
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
update.code.visualstudio.com
node /home/REDACTED/work/zephyr-ide/zephyr-ide/node_modules/.bin/vscode-test
(dns block)If you need me to access, download, or install something from one of these locations, you can either:
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.