fix: migrate ORDER_NR placeholder to ORDER_ID in label descriptions #395
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add transformation in PdkSettingsMigration to replace [ORDER_NR] with [ORDER_ID] during settings migration to maintain consistency with WooCommerce implementation and ensure the placeholder works correctly.
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a migration issue by replacing the deprecated ORDER_NR placeholder with the standardized ORDER_ID placeholder in label descriptions during PDK settings migration.
- Adds mapping to transform
[ORDER_NR]placeholders to[ORDER_ID]in the settings transformation process
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
NabDevs
force-pushed
the
fix/order-nr-placeholder-migration
branch
2 times, most recently
from
556f53e to
41da6a0
Compare
joerivanveen
approved these changes
Sep 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.