Add composer package setup. #32
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mzur
requested changes
Sep 10, 2021
Comment on lines
+7
to
+9
| "psr-4": { | ||
| "Mzur\\KirbyCalendarPlugin\\": "src/" | ||
| } |
There was a problem hiding this comment.
Thanks! This won't initialize the plugin correctly, though, as the index.php is no longer executed. Instead, a files autoload section should work:
Suggested change
| "psr-4": { | |
| "Mzur\\KirbyCalendarPlugin\\": "src/" | |
| } | |
| "files": [ | |
| "index.php" | |
| ] |
Also, the index.php will need a use statement for the Kirby class, similar to this one.
You could also add authors and support sections.
Could you please apply the changes and test them?
| { | ||
| "name": "mzur/kirby-calendar-plugin", | ||
| "description": "A plugin for the Kirby CMS to easily implement an event calendar.", | ||
| "type": "composer-plugin", |
There was a problem hiding this comment.
Suggested change
| "type": "composer-plugin", | |
| "type": "library", |
| "name": "mzur/kirby-calendar-plugin", | ||
| "description": "A plugin for the Kirby CMS to easily implement an event calendar.", | ||
| "type": "composer-plugin", | ||
| "license": "GNU GPL v2", |
There was a problem hiding this comment.
Suggested change
| "license": "GNU GPL v2", | |
| "license": "GPL-2.0-only", |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This targets #31.