Skip to content

Add env variable to stop logging of http cookie warnings #265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Add env variable to stop logging of http cookie warnings #265

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b980ec2
Add env variable to stop logging of http cookie warnings
Sep 16, 2015
9b5ced6
Use string rather than boolean for env & fix 1 log check
Sep 16, 2015
8656618
Merge pull request #1 from kat3kasper/feature/http-cookie-logs
kat3kasper Sep 17, 2015
7e9efc9
Merge branch 'master' into master
kat3kasper Jun 22, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions lib/httpclient/cookie.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ def add(cookie)
end

def find(uri)
warning('CookieManager#find is deprecated and will be removed in near future. Use HTTP::Cookie.cookie_value(CookieManager#cookies) instead')
warning('CookieManager#find is deprecated and will be removed in near future. Use HTTP::Cookie.cookie_value(CookieManager#cookies) instead') if log_http_cookie_warnings?
if cookie = cookies(uri)
HTTP::Cookie.cookie_value(cookie)
end
Expand Down Expand Up @@ -197,7 +197,7 @@ def http_only?
alias original_domain domain

def domain
warning('Cookie#domain returns dot-less domain name now. Use Cookie#dot_domain if you need "." at the beginning.')
warning('Cookie#domain returns dot-less domain name now. Use Cookie#dot_domain if you need "." at the beginning.') if log_http_cookie_warnings?
self.original_domain
end

Expand All @@ -209,11 +209,14 @@ def flag
private

def deprecated(old, new)
warning("WebAgent::Cookie is deprecated and will be replaced with HTTP::Cookie in the near future. Please use Cookie##{new} instead of Cookie##{old} for the replacement.")
warning("WebAgent::Cookie is deprecated and will be replaced with HTTP::Cookie in the near future. Please use Cookie##{new} instead of Cookie##{old} for the replacement.") if log_http_cookie_warnings?
end
end
end

def log_http_cookie_warnings?
ENV['HTTPCLIENT_LOG_HTTP_COOKIE_WARNING'] != "disabled"
end
rescue LoadError
require 'httpclient/webagent-cookie'
end
Expand Down