Skip to content

Conversation

feliam
Copy link
Contributor

@feliam feliam commented Apr 2, 2025

  • Added prometheus rules linter (pint) to the CI
  • Removed redundant "NamadaBlockProcessingSlow" rule
  • Added low level alert rule to allow the monitor to generate alerts directly
  • Fix rule NamadaAbnormalUnbonding filtering by chain id
  • Added chain id to all summary/descriptions
  • Checksums are retrieved only on epoch changes

@feliam feliam closed this Apr 2, 2025
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request was validated by pint.

❗ Problems found.

Severity Number of problems
Warning 2
Stats

Stat Value
Version 0.71.8
Number of rules parsed 17
Number of rules checked 17
Number of problems found 2
Number of offline checks 113
Number of online checks 0
Checks duration 4ms

Problems

Warning: dead code in query (promql/impossible)
  ---> composer/provisioning/prometheus/namada-alerts.yml:56 -> `NamadaTransactionBatchSpike`
56 |       rate(namada_transaction_batch_size_count{ chain_id="$$CHAIN_ID$$" }[10m]) > (2 * quantile(0.50, rate(namada_transaction_batch_size_count{ chain_id="$$CHAIN_ID$$" }[7d])))
                                                                                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ The right hand side will never be matched because it doesn't have the `chain_id` label while the left hand side will. Query is using aggregation that removes all labels.

Warning: dead code in query (promql/impossible)
  ---> composer/provisioning/prometheus/namada-alerts.yml:78-80 -> `AbnormalInnerTransactionFailureRate`
78 |       (rate(namada_transaction_kind{chain_id="$$CHAIN_ID$$", failed="true"}[10m]) / rate(namada_transaction_kind{chain_id="$$CHAIN_ID$$"}[10m]))
79 |       >
80 |       (2 * quantile(0.50, rate(namada_transaction_kind{chain_id="$$CHAIN_ID$$", failed="true"}[7d:]) / rate(namada_transaction_kind{chain_id="$$CHAIN_ID$$"}[7d:])))
                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ The right hand side will never be matched because it doesn't have the `chain_id` label while the left hand side will. Query is using aggregation that removes all labels.

@feliam feliam reopened this Apr 2, 2025
@feliam feliam changed the title Dev/slashes test Refactor and low level rules Apr 2, 2025
@feliam feliam merged commit 341149a into main Apr 23, 2025
3 checks passed
@feliam feliam deleted the dev/slashes_test branch April 23, 2025 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant