-
-
Couldn't load subscription status.
- Fork 27
Add notices to various readmes #48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters (2)
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including You can disable this status message by setting the WalkthroughThe pull request removes the conditional logic and job definition related to the STM32 GpioController extension in the Azure Pipelines configuration. The changes eliminate the mechanism that detected modifications in the STM32 GpioController files and, accordingly, the entire job designed to build, package, collect, and publish artifacts for that extension. Changes
Sequence Diagram(s)sequenceDiagram
participant Dev as Developer
participant Repo as Git Repository
participant Pipeline as Azure Pipeline
participant Build as STM32 Build Job
Dev->>Repo: Push changes (including STM32 extension files)
Repo->>Pipeline: Trigger pipeline
Pipeline->>Pipeline: Evaluate changes
alt Previously
Pipeline->>Build: Initiate STM32 build job
Build->>Pipeline: Return build artifacts
else Now
Pipeline-->>Dev: Skip STM32 build job (job removed)
end
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
| @@ -1,5 +1,7 @@ | |||
| # SD card and internal storage support for nanoFramework | |||
|
|
|||
| ## ⚠️ This sample is potentially superseded with the [FileSystem Sample](https://github.com/nanoframework/Samples/tree/main/samples/System.IO.FileSystem). ⚠️ | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe it's safe to remove this. There is indeed a better sample elsewhere.
| @@ -1,5 +1,7 @@ | |||
| # ESP32 WS2812 Driver | |||
|
|
|||
| ## ⚠️ This driver is potentially superseded with [nanoFramework.IoT.Device.Ws28xx](https://github.com/nanoframework/nanoFramework.IoT.Device/tree/develop/devices/Ws28xx). ⚠️ | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe it's safe to remove this. There is indeed a better library elsewhere.
|
|
||
| # NanoFramework SSD1306 Oled 128x64, 128x32, 64x48, 96x16 display driver | ||
|
|
||
| ## ⚠️ This driver is potentially superseded with [nanoFramework.IoT.Device.Ssd13xx](https://github.com/nanoframework/nanoFramework.IoT.Device/tree/develop/devices/Ssd13xx). ⚠️ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe it's safe to remove this. There is indeed a better driver elsewhere.
| @@ -1,5 +1,7 @@ | |||
| # RFID MFRC522 driver support for nanoFramework | |||
|
|
|||
| ## ⚠️ This driver is potentially superseded with [nanoFramework.IoT.Device.Mfrc522](https://github.com/nanoframework/nanoFramework.IoT.Device/tree/develop/devices/Mfrc522). ⚠️ | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe it's safe to remove this. There is indeed a better driver elsewhere.
| @@ -1,4 +1,7 @@ | |||
| # Driver for DS18B20 | |||
|
|
|||
| ## ⚠️ This driver is potentially superseded with [nanoFramework.IoT.Device.Ds18b20](https://github.com/nanoframework/nanoFramework.IoT.Device/tree/develop/devices/Ds18b20). ⚠️ | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe it's safe to remove this. There is indeed a better library elsewhere.
| @@ -1,4 +1,7 @@ | |||
| # nanoFramework Web Server | |||
|
|
|||
| ## ⚠️ This sample is potentially superseded with the [Webserver Sample](https://github.com/nanoframework/Samples/tree/main/samples/Webserver). ⚠️ | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe it's safe to remove this. There is indeed a better library elsewhere.
| @@ -1,5 +1,7 @@ | |||
| # nanoFramework.Modbus | |||
|
|
|||
| ## ⚠️ This library is potentially superseded with [nanoFramework.IoT.Device.Modbus](https://github.com/nanoframework/nanoFramework.IoT.Device/tree/develop/devices/Modbus). ⚠️ | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe it's safe to remove this. There is indeed a better library elsewhere.
| @@ -1,5 +1,7 @@ | |||
| # GpiController extension for STM32 targets | |||
|
|
|||
| ## ⚠️ This extension is obsolete and no longer used with current firmware versions. ⚠️ | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let me update it to use Sys.Device.Gpio instedad.
Added notices to various readmes to note that better (official) options may now be available, whilst also keeping the spirit of the initial contribution.
Also adjusts the pipeline to no longer build the GPIO pin lib for STM32 devices as now obsolete.
Checklist:
Summary by CodeRabbit