Skip to content

Conversation

@networkfusion
Copy link
Member

@networkfusion networkfusion commented Mar 20, 2025

Added notices to various readmes to note that better (official) options may now be available, whilst also keeping the spirit of the initial contribution.

Also adjusts the pipeline to no longer build the GPIO pin lib for STM32 devices as now obsolete.

Checklist:

  • I've placed my contribution in the appropriate section.
  • I've choosen a good name for it and I've checked the repo for duplicates.
  • I've added a readme.md following the provided template (TBD).
  • My code follows the code style of this project.
  • I've tidy my files inside the contribution folder.
  • I've edited the repo README.md to include the mention and link to my contribution. It's under the proper section and the link is correct.
  • The code builds.

Summary by CodeRabbit

  • Chores
    • Streamlined the automated build process by removing an outdated build step for a specific extension. These updates simplify the deployment pipeline and improve overall efficiency while ensuring the platform continues to perform reliably without affecting your current experience.

@coderabbitai
Copy link

coderabbitai bot commented Mar 20, 2025

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (2)
  • .github/PULL_REQUEST_TEMPLATE.md is excluded by !**/*.md and included by none
  • libraries/nanoFramework.Modbus/README.md is excluded by !**/*.md and included by none

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

The pull request removes the conditional logic and job definition related to the STM32 GpioController extension in the Azure Pipelines configuration. The changes eliminate the mechanism that detected modifications in the STM32 GpioController files and, accordingly, the entire job designed to build, package, collect, and publish artifacts for that extension.

Changes

File(s) Change Summary
azure-pipelines.yml Removed conditional block that set the BUILD_STM32_GPIOCONTROLLER variable based on file changes in the STM32 extension. Removed the entire job definition (Build_STM32_GpioController) along with its steps for building, packaging, artifact collection, publication, and NuGet package pushing.

Sequence Diagram(s)

sequenceDiagram
    participant Dev as Developer
    participant Repo as Git Repository
    participant Pipeline as Azure Pipeline
    participant Build as STM32 Build Job

    Dev->>Repo: Push changes (including STM32 extension files)
    Repo->>Pipeline: Trigger pipeline
    Pipeline->>Pipeline: Evaluate changes
    alt Previously
        Pipeline->>Build: Initiate STM32 build job
        Build->>Pipeline: Return build artifacts
    else Now
        Pipeline-->>Dev: Skip STM32 build job (job removed)
    end
Loading

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@@ -1,5 +1,7 @@
# SD card and internal storage support for nanoFramework

## ⚠️ This sample is potentially superseded with the [FileSystem Sample](https://github.com/nanoframework/Samples/tree/main/samples/System.IO.FileSystem). ⚠️
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe it's safe to remove this. There is indeed a better sample elsewhere.

@@ -1,5 +1,7 @@
# ESP32 WS2812 Driver

## ⚠️ This driver is potentially superseded with [nanoFramework.IoT.Device.Ws28xx](https://github.com/nanoframework/nanoFramework.IoT.Device/tree/develop/devices/Ws28xx). ⚠️
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe it's safe to remove this. There is indeed a better library elsewhere.


# NanoFramework SSD1306 Oled 128x64, 128x32, 64x48, 96x16 display driver

## ⚠️ This driver is potentially superseded with [nanoFramework.IoT.Device.Ssd13xx](https://github.com/nanoframework/nanoFramework.IoT.Device/tree/develop/devices/Ssd13xx). ⚠️
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe it's safe to remove this. There is indeed a better driver elsewhere.

@@ -1,5 +1,7 @@
# RFID MFRC522 driver support for nanoFramework

## ⚠️ This driver is potentially superseded with [nanoFramework.IoT.Device.Mfrc522](https://github.com/nanoframework/nanoFramework.IoT.Device/tree/develop/devices/Mfrc522). ⚠️
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe it's safe to remove this. There is indeed a better driver elsewhere.

@@ -1,4 +1,7 @@
# Driver for DS18B20

## ⚠️ This driver is potentially superseded with [nanoFramework.IoT.Device.Ds18b20](https://github.com/nanoframework/nanoFramework.IoT.Device/tree/develop/devices/Ds18b20). ⚠️
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe it's safe to remove this. There is indeed a better library elsewhere.

@@ -1,4 +1,7 @@
# nanoFramework Web Server

## ⚠️ This sample is potentially superseded with the [Webserver Sample](https://github.com/nanoframework/Samples/tree/main/samples/Webserver). ⚠️
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe it's safe to remove this. There is indeed a better library elsewhere.

@@ -1,5 +1,7 @@
# nanoFramework.Modbus

## ⚠️ This library is potentially superseded with [nanoFramework.IoT.Device.Modbus](https://github.com/nanoframework/nanoFramework.IoT.Device/tree/develop/devices/Modbus). ⚠️
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe it's safe to remove this. There is indeed a better library elsewhere.

@@ -1,5 +1,7 @@
# GpiController extension for STM32 targets

## ⚠️ This extension is obsolete and no longer used with current firmware versions. ⚠️
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me update it to use Sys.Device.Gpio instedad.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants