Add example, Fix get_cmap #213
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add to the example of plotting on the brain by plotting the atlas regions on the brain. Catch an exception caused by matplotlib 3.9 breaking plt.cm.get_cmap() and replacing it with plt.get_cmap()
There was a problem hiding this comment.
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (2)
naplib/utils/surfdist.py:183
- Consider checking if plt.cm.get_cmap exists using hasattr instead of relying solely on catching AttributeError, which might mask unexpected errors.
try:
examples/brain_plotting/plot_intracranial_electrodes.py:125
- [nitpick] Consider adding a more descriptive comment header that briefly explains the purpose of the added atlas overlay section.
###############################################################################
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add to the example of plotting on the brain by plotting the atlas regions on the brain.
Catch an exception caused by matplotlib 3.9 breaking plt.cm.get_cmap() and replacing it with plt.get_cmap()
Reference Issues/PRs
What does this implement/fix? Explain your changes.
Fixed break in matplotlib 3.9 plt.cm.get_cmap() deprecated
Added example
Any other comments?
Add to the example of plotting on the brain by plotting the atlas regions on the brain.
Catch an exception caused by matplotlib 3.9 breaking plt.cm.get_cmap() and replacing it with plt.get_cmap()Add to the example of plotting on the brain by plotting the atlas regions on the brain.
Catch an exception caused by matplotlib 3.9 breaking plt.cm.get_cmap() and replacing it with plt.get_cmap()