Skip to content

Conversation

ank1m
Copy link
Collaborator

@ank1m ank1m commented Sep 8, 2025

GitHub Issue: #186

Description

Filename regex pattern used for TEMPO collections fails because for NRT collections extra _NRT_ label is included in the filename.
For example, for standard collections, say TEMPO_HCHO_L2_V04_20250101T000000Z_S001G01.nc
Image

But in case of NRT collections, additional suffix _NRT_ is present: TEMPO_HCHO_L2_NRT_V04_20250101T000000Z_S001G01.nc
So extra regex term needs to be included to capture optional _NRT_ suffix, similarly to proxy term:

image

Local test steps

  • Deployed updated batchee in a local Harmony environment and observed successful processing for NRT collections, as well as STANDARD collections.

Overview of integration done

  • Deployed updated batchee in a local Harmony environment and observed successful processing for NRT collections, as well as STANDARD collections.

  • NRT example: image

  • STD example: image

PR Acceptance Checklist

  • Unit tests added/updated and passing.
  • Integration testing
  • CHANGELOG.md updated
  • Documentation updated (if needed).

@danielfromearth
Copy link
Collaborator

@ank1m, looks good!. With an update to the changelog this will be ready to go!

@codecov-commenter
Copy link

codecov-commenter commented Sep 8, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.10%. Comparing base (b7f6d67) to head (85a122c).
⚠️ Report is 1 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #187   +/-   ##
========================================
  Coverage    85.10%   85.10%           
========================================
  Files            4        4           
  Lines          141      141           
========================================
  Hits           120      120           
  Misses          21       21           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ank1m ank1m marked this pull request as ready for review September 8, 2025 20:19
@danielfromearth danielfromearth added the enhancement New feature or request label Sep 8, 2025
@danielfromearth danielfromearth self-requested a review September 8, 2025 20:42
@danielfromearth danielfromearth merged commit 85b62e4 into develop Sep 8, 2025
5 checks passed
@danielfromearth danielfromearth deleted the feature/issue-186-optional-NRT-label branch September 8, 2025 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants