Skip to content

Conversation

bnp26
Copy link
Contributor

@bnp26 bnp26 commented Oct 8, 2024

Overview

What is the feature?

Exposed EntryId to collections graphql requests

What is the Solution?

Added EntryId to collection.graphql

What areas of the application does this impact?

graphql-cmr

Testing

Reproduction steps

  • Environment for testing:
  • Collection to test with:
  1. make a new graphql call with the following query
    query GetProjectCollections(
    $params: CollectionsInput
    ) {
    collections(params: $params) {
    items {
    entryId
    shortName
    version
    }
    }
    }

  2. ensure entryId is returned in the response

Attachments

Please include relevant screenshots or files that would be helpful in reviewing and verifying this change.

Checklist

  • I have added automated tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Copy link

codecov bot commented Oct 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (2ae05dd) to head (becf5a1).

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #137   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          106       106           
  Lines         2344      2344           
  Branches       262       262           
=========================================
  Hits          2344      2344           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@macrouch macrouch merged commit 1c9e321 into nasa:main Oct 8, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants