Skip to content

Conversation

mandyparson
Copy link
Contributor

@mandyparson mandyparson commented Jul 15, 2025

Overview

What is the feature?

The following fields were missing from Citation and needed to be added: providerId, revisionDate, revisionId, revisions, and userId

What is the Solution?

added those fields

What areas of the application does this impact?

Citations

Testing

Reproduction steps

  • **Environment for testing: SIT
  • **Collection to test with: CIT1200484675-DEMO_PROV
  1. The above Citation has four revisions.
  2. Use this query in apollo studio to ensure that all fields now return
    query Citation($params: CitationInput) {
    citation(params: $params) {
    abstract
    citationMetadata
    conceptId
    identifier
    identifierType
    name
    nativeId
    providerId
    resolutionAuthority
    relatedIdentifiers
    revisionDate
    revisionId
    revisions {
    count
    items {
    conceptId
    revisionDate
    revisionId
    userId
    }
    }
    scienceKeywords
    userId
    }
    }

Attachments

Please include relevant screenshots or files that would be helpful in reviewing and verifying this change.

Checklist

  • I have added automated tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Copy link

codecov bot commented Jul 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (1ed8c26) to head (469e370).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #171   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          113       113           
  Lines         2630      2635    +5     
  Branches       313       314    +1     
=========================================
+ Hits          2630      2635    +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mandyparson mandyparson merged commit 8b71e8a into main Jul 17, 2025
9 checks passed
@mandyparson mandyparson deleted the GQL-122 branch July 17, 2025 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants