Skip to content

Conversation

william-valencia
Copy link
Contributor

@william-valencia william-valencia commented Jul 18, 2025

Overview

What is the feature?

Allow Citation to return ummMetadata

What is the Solution?

Add ummMetadata to graphQL

What areas of the application does this impact?

Citation

Testing

Make sure you can get ummMetadata from a Citation in graphQL

  • Environment for testing:
  • Collection to test with:

Login to Apollo Studio
Make sure you can get ummMetadata from Citation ie

query ExampleQuery {
citation {
conceptId
ummMetadata
}
}

Attachments

Screenshot 2025-07-18 at 1 17 05 AM

Please include relevant screenshots or files that would be helpful in reviewing and verifying this change.

Checklist

  • I have added automated tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Copy link

codecov bot commented Jul 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (8b71e8a) to head (2d7f6c4).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #172   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          113       113           
  Lines         2635      2635           
  Branches       314       314           
=========================================
  Hits          2635      2635           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@mandyparson mandyparson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good! Can run an npm audit fix to get rid of the that critical bug

@william-valencia william-valencia merged commit e47c5a2 into main Jul 23, 2025
9 checks passed
@william-valencia william-valencia deleted the GQL-123 branch July 23, 2025 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants