Skip to content

Conversation

mandyparson
Copy link
Contributor

@mandyparson mandyparson commented Aug 28, 2025

Overview

What is the feature?

Add Keyword to visualizations input so that user can send a keyword as a param when querying all visualizations

What is the Solution?

added keyword

What areas of the application does this impact?

Visualizations

Testing

Reproduction steps

  • **Environment for testing: SIT
  • Collection to test with:

query Visualizations($params: VisualizationsInput) {
visualizations(params: $params) {
count
items {
name
title
conceptId
}
}
}

  1. Query Visualizations when keyword is null
    {
    "params": {
    "keyword": null,
    }
    }

  2. Query visualizations when keyword is "rock"
    {
    "params": {
    "keyword": "rock"
    }
    }

Please note that when keyword is "rock paper scissor" it does not work. This is a known bug.

Attachments

Screenshot 2025-08-28 at 11 22 35 AM

Checklist

  • I have added automated tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Copy link

codecov bot commented Aug 28, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (c28bda3) to head (814cc15).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #175   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          115       115           
  Lines         2694      2694           
  Branches       328       328           
=========================================
  Hits          2694      2694           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@eudoroolivares2016 eudoroolivares2016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at it locally npm audit fix seems to make the snyk cli tool happy

"Cursor that points to a specific position in a list of requested records."
cursor: String

"Keyword search value."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not really in your PR but, would having "Science Keyword in scienceKeywords" maybe be more accurate in src/types/citation.graphql?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right now in citation.graphql it's "Science Keywords in keywords" which makes more sense to me because we are looking for only science keywords in keywords, not scienceKeywords.

@mandyparson mandyparson merged commit 62c4584 into main Aug 29, 2025
9 checks passed
@mandyparson mandyparson deleted the GQL-128 branch August 29, 2025 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants