-
Notifications
You must be signed in to change notification settings - Fork 9
GQL-128: Add Keyword to visualizations input #175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #175 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 115 115
Lines 2694 2694
Branches 328 328
=========================================
Hits 2694 2694 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking at it locally npm audit fix seems to make the snyk cli tool happy
"Cursor that points to a specific position in a list of requested records." | ||
cursor: String | ||
|
||
"Keyword search value." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not really in your PR but, would having "Science Keyword in scienceKeywords"
maybe be more accurate in src/types/citation.graphql
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right now in citation.graphql it's "Science Keywords in keywords" which makes more sense to me because we are looking for only science keywords in keywords, not scienceKeywords.
Overview
What is the feature?
Add Keyword to visualizations input so that user can send a keyword as a param when querying all visualizations
What is the Solution?
added keyword
What areas of the application does this impact?
Visualizations
Testing
Reproduction steps
query Visualizations($params: VisualizationsInput) {
visualizations(params: $params) {
count
items {
name
title
conceptId
}
}
}
Query Visualizations when keyword is null
{
"params": {
"keyword": null,
}
}
Query visualizations when keyword is "rock"
{
"params": {
"keyword": "rock"
}
}
Please note that when keyword is "rock paper scissor" it does not work. This is a known bug.
Attachments
Checklist