Skip to content

GQL-128: Add Keyword to visualizations input #175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 29, 2025
Merged

GQL-128: Add Keyword to visualizations input #175

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6380df2
GQL-128: Adding keyword param to visualizations
mandyparson Aug 28, 2025
814cc15
GQL-128: Running npm audit fix
mandyparson Aug 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
143 changes: 95 additions & 48 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 4 additions & 2 deletions src/cmr/concepts/visualization.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,8 @@ export default class Visualization extends Concept {
...super.getPermittedJsonSearchParams(),
'name',
'provider',
'title'
'title',
'keyword'
]
}

Expand All @@ -31,7 +32,8 @@ export default class Visualization extends Concept {
...super.getPermittedUmmSearchParams(),
'name',
'provider',
'title'
'title',
'keyword'
]
}

Expand Down
3 changes: 3 additions & 0 deletions src/types/visualization.graphql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,9 @@ input VisualizationsInput {
"Cursor that points to a specific position in a list of requested records."
cursor: String

"Keyword search value."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not really in your PR but, would having "Science Keyword in scienceKeywords" maybe be more accurate in src/types/citation.graphql?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right now in citation.graphql it's "Science Keywords in keywords" which makes more sense to me because we are looking for only science keywords in keywords, not scienceKeywords.

keyword: String

"The number of visualizations requested by the user."
limit: Int

Expand Down