Skip to content

Conversation

mandyparson
Copy link
Contributor

Overview

What is the feature?

You can query for associatedCitations on a Collection and receive back a valid response. As is the case with Collection: C1200484122-MMT_2. It is associated with CIT1200485865-MMT_2 however you won't see that association in cmr anywhere as it only exists in graphdb.

In graphql, we need to expose the citations that are found in the associationDetails/cmr like we do for variables, services, and tools.

What is the Solution?

Added citations to collection.graphql and created the resolver

What areas of the application does this impact?

Collection.graphql
collection/resolver

Testing

Reproduction steps

  • **Environment for testing: SIT
  • **Collection to test with:
    Collection to associate to: C1200411035-ARCTEST
    Citation to associate to above Collection: CIT1200485769-MMT_1
  1. In graphql, query for collection.citations and collection.associatedDetails
  2. Make sure the conceptIds in associatedDetails corrolate with what's in collection.citations

Attachments

Screenshot 2025-09-24 at 7 59 18 AM

Please include relevant screenshots or files that would be helpful in reviewing and verifying this change.

Checklist

  • I have added automated tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Copy link

codecov bot commented Sep 24, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (62c4584) to head (2f5c795).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #176   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          115       115           
  Lines         2694      2694           
  Branches       328       328           
=========================================
  Hits          2694      2694           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@eudoroolivares2016
Copy link
Contributor

sent you some PM about where the uncovered parts are

@eudoroolivares2016 eudoroolivares2016 changed the title GQL-130: Exposing associated citations from CMR on Collection GQL-130: Exposing associated citations from CMR on Collection and disable associatedCitations from graphdb for now Sep 25, 2025
@mandyparson mandyparson merged commit f4f11ce into main Sep 25, 2025
9 checks passed
@mandyparson mandyparson deleted the GQL-130 branch September 25, 2025 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants