Skip to content

Conversation

daniel-zamora
Copy link
Contributor

Because EDSC also has a tree component with identical class names, we were seeing css collisions causing unintended behavior. I've moved some echoform css into this repo where it belongs and updated the tree and tree item css to use ef- prefix on the class names to namespace these components and avoid conflicts within EDSC.

Copy link

codecov bot commented Nov 8, 2024

Codecov Report

Attention: Patch coverage is 90.90909% with 1 line in your changes missing coverage. Please review.

Project coverage is 97.52%. Comparing base (2d61b46) to head (2ed2120).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/components/Tree/TreeItem.js 90.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #126   +/-   ##
=======================================
  Coverage   97.52%   97.52%           
=======================================
  Files          43       43           
  Lines         930      931    +1     
  Branches      226      226           
=======================================
+ Hits          907      908    +1     
  Misses         23       23           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@macrouch
Copy link
Contributor

Looks good, but be sure to update the version in package.json and run npm install and commit those changes

@daniel-zamora daniel-zamora merged commit 1091550 into main Nov 13, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants