Skip to content

Conversation

KushaalP
Copy link
Contributor

@KushaalP KushaalP commented Jun 13, 2025

Overview

What is the feature?

Preventing submit on enter in every form element.

What is the Solution?

Adding prevent default on enter key press on every form element.

What areas of the application does this impact?

EchoForms formbodies

Testing

Reproduction steps

  1. Go to Earthdata Search
  2. Find a collection with form elements, like band subsetting
  3. Focus on the form elements and click enter, no submission should occur

Attachments

n/a

Checklist

  • I have added automated tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • [] I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have bumped the version field in package.json and ran npm install

Copy link

codecov bot commented Jun 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.54%. Comparing base (c2e721f) to head (f242a64).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #128   +/-   ##
=======================================
  Coverage   97.53%   97.54%           
=======================================
  Files          43       43           
  Lines         932      935    +3     
  Branches      227      227           
=======================================
+ Hits          909      912    +3     
  Misses         23       23           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@KushaalP KushaalP merged commit 2d8462d into main Jun 16, 2025
8 checks passed
@KushaalP KushaalP deleted the feature/EDSC-2664 branch June 16, 2025 17:49
@KushaalP KushaalP restored the feature/EDSC-2664 branch June 16, 2025 17:49
@macrouch macrouch deleted the feature/EDSC-2664 branch June 16, 2025 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants