Skip to content

Conversation

sudha-murthy
Copy link
Contributor

@sudha-murthy sudha-murthy commented Feb 24, 2025

Description

  • The updates provides a solution to a test case where the granule has no dimensions and multiple coordinate variables are in the same group. The fix calculates the cached internal dimension names created from the coordinates to include the full name path of both the latitude and longitude coordinate variables.
  • Also added the bug fix in get_valid_sample_pts for 3D variables.
  • The issue encountered in DAS-2317 is corrected with configuration for coordinate variables with no coordinate attributes in SMAP L3

Jira Issue ID

DAS-2284

Local Test Steps

  • The unit tests should pass.
  • Hoss SMAP L3 end to end requests should pass
    More Test instructions on the ticket DAS-2284

PR Acceptance Checklist

  • [X ] Jira ticket acceptance criteria met.
  • [X ] CHANGELOG.md updated to include high level summary of PR changes.
  • [ X] docker/service_version.txt updated if publishing a release.
  • [X ] Tests added/updated and passing.
  • Documentation updated (if needed).

@sudha-murthy sudha-murthy requested review from a team and D-Auty February 24, 2025 18:36
Copy link
Contributor

@joeyschultz joeyschultz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, the changes look good! I just had a few minor comments. The unit tests all passed, but I still need to go through the rest of the test instructions.

@sudha-murthy
Copy link
Contributor Author

@joeyschultz @D-Auty - I have addressed the comments in the commit 38f6b50
Please let me know if anything else needs to be addressed.

Copy link
Contributor

@joeyschultz joeyschultz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates Sudha!

@sudha-murthy sudha-murthy merged commit 4cab420 into main Feb 26, 2025
4 checks passed
@sudha-murthy sudha-murthy deleted the DAS-2284 branch February 26, 2025 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants