-
Notifications
You must be signed in to change notification settings - Fork 4
Das 2284 #31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Das 2284 #31
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, the changes look good! I just had a few minor comments. The unit tests all passed, but I still need to go through the rest of the test instructions.
@joeyschultz @D-Auty - I have addressed the comments in the commit 38f6b50 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the updates Sudha!
Description
Jira Issue ID
DAS-2284
Local Test Steps
More Test instructions on the ticket DAS-2284
PR Acceptance Checklist
CHANGELOG.md
updated to include high level summary of PR changes.docker/service_version.txt
updated if publishing a release.