-
Notifications
You must be signed in to change notification settings - Fork 4
DAS-2339 - Add EASE_row_index and EASE_column_index as required variables. #33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
CHANGELOG.md
Outdated
### 2025-05-21 | ||
|
||
This version of HOSS updates the hoss configuration file to include | ||
EASE_column_index and EASE_row_index as ancillary variables for SPL2SMAP_S |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
DAS-2339 AC says SMAP L3. Is it both SPL2SMAP and SPL3SMAP?
AC:
'The requested output from HOSS should contain EASE_row_index and EASE_col_index for SMAP L3 collections and the regression tests should be successful'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can do it for all collections. But we decided to only implement it this way for SPL2SMAP_S. The other collections uses the index ranges from the history attribute to determine the subset index.
tests/unit/test_subset.py
Outdated
all_variables, | ||
) | ||
with self.subTest('Variables configured as ancillary for a single group'): | ||
spl2smap_s_varinfo = VarInfoFromDmr( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line 1322-1333 is similar to Line 1347-1357. Declare on line 1259 and reuse the code?
Test harmony-opendap-subsetter: PASS Test Steps:
Build harmony-opendap-subsetter
Run harmony in a box
Open browser and verify below url process correctly
Verify (http://localhost:3000/logs/91cabacb-93a5-43b7-998f-dffbc7a4f0eb/2)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have some very minor comments but it looks good overall.
Unit tests ran successfully.
My harmony-in-a-box is broken right now so I wasn't able to run the request in the test instructions, but I'm satisfied with Vu's testing of it.
Thanks for the updates Sudha. I reran the unit tests after the dmr file update and they still pass. Marking as approved. |
Description
Metadata Annotator requires EASE_row_index and EASE_column_index to be part of the request to compute the dimension scales for SPL2SMAP_S granules. They need to be added as required fields in the output of HOSS which precedes the Metadata Annotator in the service chain.
Jira Issue ID
DAS-2339
Local Test Steps
git clone -b DAS-2339 https://github.com/nasa/harmony-opendap-subsetter
conda activate hoss
bin/build-image & bin/build-test & bin/run-test
All the unit tests should succeed.
Testing in Harmony in a box
Run harmony in a box with hoss included in the services
Do the following request
http://localhost:3000/C1268429762-EEDTEST/ogc-api-coverages/1.0.0/collections/parameter_vars/coverage/rangeset?forceAsync=true&granuleId=G1268612499-EEDTEST&variable=Soil_Moisture_Retrieval_Data_1km%2Falbedo_1km&skipPreview=true&
The request should succeed and the output file should contain the following variables
/Soil_Moisture_Retrieval_Data_1km/albedo_1km, /Soil_Moisture_Retrieval_Data_1km/EASE_column_index_1km, /Soil_Moisture_Retrieval_Data_1km/EASE_row_index_1km, /Soil_Moisture_Retrieval_Data_1km/longitude_1km, /Soil_Moisture_Retrieval_Data_1km/latitude_1km
PR Acceptance Checklist
CHANGELOG.md
updated to include high level summary of PR changes.docker/service_version.txt
updated if publishing a release.