-
Notifications
You must be signed in to change notification settings - Fork 4
DAS-2339 - Add EASE_row_index and EASE_column_index as required variables. #33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 4 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
21abad1
DAS-2339 Configure EASE_row_index and EASE_column_index as required v…
sudha-murthy 7839b76
DAS-2339 - Update json to indicate 1km and 3km in the pattern check
sudha-murthy 7129b49
DAS-2339 - Use ancillary_variables attribute to specify required vari…
sudha-murthy 68bee63
DAS-2339 Update version
sudha-murthy 1d46618
DAS-2339 Add description to the ancillary field attributes
sudha-murthy ec14b15
DAS-2339 - Remove code duplication
sudha-murthy afd6c6a
DAS-2339 Add newline for readability
sudha-murthy d1d6519
DAS-2339 - Update comments
sudha-murthy 81ebf05
DAS-2339 Reduce size of SPL2SMAP_S dmr file
sudha-murthy 195fe26
DAS-2339 Remove newline at end of json file
sudha-murthy 7c32e33
DAS-2339 Remove unwanted newline in json file
sudha-murthy File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1 @@ | ||
1.1.6 | ||
1.1.7 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
DAS-2339 AC says SMAP L3. Is it both SPL2SMAP and SPL3SMAP?
AC:
'The requested output from HOSS should contain EASE_row_index and EASE_col_index for SMAP L3 collections and the regression tests should be successful'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can do it for all collections. But we decided to only implement it this way for SPL2SMAP_S. The other collections uses the index ranges from the history attribute to determine the subset index.