DAS-2389 - Update python version to 3.12 #40

sudha-murthy · 2025-08-21T17:28:51Z

Description

Update python version to 3.12 and also update the supporting packages. The default group in conda environment was already removed in DAS-2361

Jira Issue ID

DAS-2389

Local Test Steps

git clone the current branch
do
bin/build-image,
bin/build-test,
bin/run-test
All the tests should complete successfully.

PR Acceptance Checklist

[X ] Jira ticket acceptance criteria met.
[ X] CHANGELOG.md updated to include high level summary of PR changes.
[X ] docker/service_version.txt updated if publishing a release.
[X ] Tests added/updated and passing.
[X ] Documentation updated (if needed).

joeyschultz

This looks good to me. I ran the unit tests and they all succeeded. I have one nit about whether we have an unnecessary addition to the pip_test_requirements.txt, but I'll give my approval as I don't find that to be a blocking comment.

joeyschultz · 2025-08-21T20:56:17Z

tests/pip_test_requirements.txt

+pre-commit~=4.2.0
+pycodestyle~=2.14.0
+pylint ~= 3.3.7
+astroid ~= 3.3.10


I notice that astroid is now listed in pip_test_requirements as an explicit dependency. I think we could remove it and allow pylint to handle it unless there is a specific need for it that I'm not aware of.

Will recheck.

Removed it - 62e8584

vutrannasa · 2025-08-21T21:12:57Z

docker/service.Dockerfile

-RUN conda create -y --name hoss --file conda_requirements.txt python=3.11 -q \
-	--channel conda-forge \
-	--override-channels
+RUN conda config --remove channels defaults


Do you need the RUN conda config --remove channels defaults if you are creating a new instance of a docker image?

no. I think it is there to remove any old ones

Removed it - 62e8584

flamingbear

It looks like I had a lot of the same comments that other people did. Did you also verify the regression tests are all still passing? both the regression and internal ones?

edited: I'm going to guess no?

AssertionError: Test output does not match reference file, HOSS bounding box spatial, 3-D (well ordered) request.

3 of the regressions failed.

flamingbear · 2025-08-21T20:42:57Z

docker/service.Dockerfile

-RUN conda create -y --name hoss --file conda_requirements.txt python=3.11 -q \
-	--channel conda-forge \
-	--override-channels
+RUN conda config --remove channels defaults


This is overkill since you have --override-channels on the next command, but it doesn't hurt I guess.

Removed it -62e8584

flamingbear · 2025-08-21T20:43:39Z

docker/service_version.txt

There are no changes to the functionality of the service, this should be a patch version probably?

updated it - bd2f805

flamingbear · 2025-08-21T20:47:43Z

tests/pip_test_requirements.txt

+pre-commit~=4.2.0
+pycodestyle~=2.14.0
+pylint ~= 3.3.7
+astroid ~= 3.3.10


Why did you need to add asteroid? seems like we don't import it anywhere and you can build and run the tests without it explicitly added here.

I thought I needed it. will recheck.

Removed it. - 62e8584

flamingbear · 2025-08-21T20:48:14Z

CHANGELOG.md

+## v1.2.0
+### 2025-08-21
+
+This version of HOSS updates the consa environment to support Python 3.12. This also updates the


Suggested change

This version of HOSS updates the consa environment to support Python 3.12. This also updates the

This version of HOSS updates the conda environment to support Python 3.12. This also updates the

updated - 62e8584

flamingbear · 2025-08-21T20:49:38Z

CHANGELOG.md

+### 2025-08-21
+
+This version of HOSS updates the consa environment to support Python 3.12. This also updates the
+dependent packages to their latest supportable versions. Also updates harmony library version.


Suggested change

dependent packages to their latest supportable versions. Also updates harmony library version.

dependent packages to their latest supportable versions. Also updates Harmony Service Library version.

But that's still not a complete sentence.

updated - 62e8584

sudha-murthy · 2025-08-22T14:25:01Z

It looks like I had a lot of the same comments that other people did. Did you also verify the regression tests are all still passing? both the regression and internal ones?

edited: I'm going to guess no?
AssertionError: Test output does not match reference file, HOSS bounding box spatial, 3-D (well ordered) request.
3 of the regressions failed.

Which ones failed for you Matt?
The Harmony regression tests for HOSS passed for me.
Ran a couple of the DAS harmony regression tests for SMAP . Those passed as well

flamingbear · 2025-08-22T14:49:49Z

Which ones failed for you Matt?
The Harmony regression tests for HOSS passed for me.

I rebuilt both hoss and maskfill from the branches, and they pass now. don't know what that was from. sorry.

sudha-murthy · 2025-08-22T15:48:53Z

Which ones failed for you Matt?
The Harmony regression tests for HOSS passed for me.

I rebuilt both hoss and maskfill from the branches, and they pass now. don't know what that was from. sorry.

Let me know if anything else needs to be updated for PR to be approved.

flamingbear

thanks for the updates. Looks alright to me now.

sudha-murthy added 3 commits August 21, 2025 13:16

DAS-2389 - Update python version to 3.12

daa69b9

DAS-2389 - Fix precommit errors

6a36d5b

DAS-2389 - workaround for snyk not yet supporting python 3.12

4a1349e

sudha-murthy requested a review from a team August 21, 2025 17:52

joeyschultz approved these changes Aug 21, 2025

View reviewed changes

vutrannasa reviewed Aug 21, 2025

View reviewed changes

flamingbear requested changes Aug 21, 2025

View reviewed changes

sudha-murthy added 2 commits August 22, 2025 00:41

DAS-2389 - Remove packages not needed

62e8584

DAS-2389 - Update service version

bd2f805

flamingbear approved these changes Aug 22, 2025

View reviewed changes

sudha-murthy merged commit eae00a9 into main Aug 25, 2025
4 checks passed

sudha-murthy deleted the DAS-2389 branch August 25, 2025 13:24

	This version of HOSS updates the consa environment to support Python 3.12. This also updates the
	This version of HOSS updates the conda environment to support Python 3.12. This also updates the

	dependent packages to their latest supportable versions. Also updates harmony library version.
	dependent packages to their latest supportable versions. Also updates Harmony Service Library version.

DAS-2389 - Update python version to 3.12 #40

DAS-2389 - Update python version to 3.12 #40

Uh oh!

Conversation

sudha-murthy commented Aug 21, 2025

Description

Jira Issue ID

Local Test Steps

PR Acceptance Checklist

Uh oh!

joeyschultz left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

flamingbear left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sudha-murthy commented Aug 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

flamingbear commented Aug 22, 2025

Uh oh!

sudha-murthy commented Aug 22, 2025

Uh oh!

flamingbear left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

flamingbear left a comment •

edited

Loading

sudha-murthy commented Aug 22, 2025 •

edited

Loading