Skip to content

Make heartbeat interval configurable. #4352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Make heartbeat interval configurable. #4352

wants to merge 1 commit into from

Conversation

jevolk
Copy link
Contributor

@jevolk jevolk commented Aug 1, 2023

Removes hardcoded global; resolves FIXME.

  • Link to issue, e.g. Resolves #NNN
  • Documentation added (if applicable)
  • Tests added
  • Branch rebased on top of current main (git pull --rebase origin main)
  • Changes squashed to a single commit (described here)
  • Build is green in Travis CI
  • You have certified that the contribution is your original work and that you license the work to the project under the Apache 2 license

Resolves

nats-server/server/events.go

Lines 83 to 84 in 039f63e

// FIXME(dlc) - make configurable.
var eventsHBInterval = 30 * time.Second

Tangentially related to #4227 #4234

@jevolk jevolk requested a review from a team as a code owner August 1, 2023 02:58
@wallyqs
Copy link
Member

wallyqs commented Aug 1, 2023

@jevolk could you try to change the target to be the dev branch? There would only be a minor conflict in const.go

@jevolk jevolk force-pushed the jevolk/hbinterval branch from 27252ec to ddfe7cb Compare August 1, 2023 05:58
@jevolk jevolk changed the base branch from main to dev August 1, 2023 06:00
@jevolk jevolk force-pushed the jevolk/hbinterval branch from ddfe7cb to 9616e1f Compare August 7, 2023 17:20
@jevolk
Make events heartbeat interval configurable.
a113283 
Removes hardcoded global; resolves FIXME.

Signed-off-by: Jason Volk <jason@zemos.net>
@jevolk jevolk force-pushed the jevolk/hbinterval branch from 9616e1f to a113283 Compare August 20, 2023 03:28
@neilalexander neilalexander added the post-freeze We'll come back to this after the freeze period label Aug 21, 2023
@paolobarbolini paolobarbolini mentioned this pull request Sep 25, 2023
Open
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
post-freeze We'll come back to this after the freeze period
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jevolk @wallyqs @neilalexander