Disable streaming by default (#770)

* Windows build tests

* Exclude windows test flappers

* Exclude windows test flappers 2

* Exclude test flappers

* Added rerun-failed option

* Rerun-failed retry

* Rerun-failed retry

* Exclude fails and flappers

* Rerun-failed retry

* Rerun-failed retry

* Commented out excludes

* Removed test excludes

* Server download versions

* Server download versions

* Server download latest

* Travis fix

---------

Co-authored-by: Lev <1187448+levb@users.noreply.github.com>

Author: mtmk

CMakeLists.txt

@@ -41,7 +41,14 @@ option(NATS_BUILD_EXAMPLES "Build examples" ON)
 option(NATS_BUILD_LIBUV_EXAMPLE "Build libuv examples" OFF)
 option(NATS_BUILD_LIBEVENT_EXAMPLE "Build libevent examples" OFF)
 option(NATS_BUILD_STATIC_EXAMPLES "Statically link examples" OFF)
-option(NATS_BUILD_STREAMING "Build NATS Streaming" ON)
+
+# Streaming is deprecated, but we still support it for now.
+# We will remove it in the future. If you are starting a new project,
+# please use JetStream. Another reason for disabling this is that
+# building with streaming requires protobuf-c and building on Windows
+# is not as straightforward as building without it.
+option(NATS_BUILD_STREAMING "Build NATS Streaming" OFF)
+
 option(NATS_BUILD_NO_PREFIX_CONNSTS "No prefix for connection status enum" OFF)
 option(NATS_BUILD_LIB_STATIC "Build static library" ON)
 option(NATS_BUILD_LIB_SHARED "Build shared library" ON)

buildOnTravis.sh

@@ -54,7 +54,7 @@ if [ "$1" != "gcc" ]; then
   fi
 fi
 
-cmake .. $3
+cmake .. $3 -DNATS_BUILD_STREAMING=ON
 res=$?
 if [ $res -ne 0 ]; then
   exit $res