added proxyConnectCb (#870) #871
Conversation
|
for context @wolfkor helped us adding this feature to .NET client nats-io/nats.net#826 I'm assuming this is to implement the same here. I think the idea here has lots of potential even though the main use case now is to punch through (probably corporate) proxies. It sounds good to me in general. I shall leave it to @levb and @kozlovic if it's something they want to consider. |
|
It's a pity that nothing is happening here @kozlovic |
There was a problem hiding this comment.
Sorry for the delay. I am not certain of the intended use-case, so I would need more information about how you plan to use that. Also, we would really need to add some tests (for instance provide a callback that returns an error and verify that connection fails), and one callback that does create socket ok. If you don't know how to add a test, I could add it after merging (if we accept the PR once we resolve the issues). Thanks!
|
After wasting my time with these damned formatting issues, i will write the test another day |
|
@wolfkor I am going to close this PR and I have submitted PR #897 that fixes formatting issues and the test (and some little changes). I have used your previous commits and squashed them into one and then added a commit with my changes. You are mentioned as the author of the PR. I hope this approach is ok (I think it would have been painful for both of us to have you make the formatting changes in your PR with your current editor settings). Thanks! |
add proxyConnectCb for TLS connection via proxy (#870)