[FXIED] LibEvent: natsConnection_Close() not closing the TCP connection #882
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was likely introduced in PR #815 when delaying the close of the socket based on the event loop adapter invoking a NATS C callback to indicate that it is safe to do so. The `libuv` adapter is doing the right thing, however the `libevent` was not since it was creating a one-time event based on `EV_TIMEOUT` passing the socket to close, however, in that mode the socket from the callback is always set to `-1`. We have to pass the socket to close though the `nle` object. I also made the `natsLibevent_Detach()` function schedule an event to ensure that a `_freeCb` is now invoked *after* execution of the `_closeCb`. Resolves #879 Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #882 +/- ##
==========================================
+ Coverage 68.71% 70.09% +1.38%
==========================================
Files 39 47 +8
Lines 15207 15555 +348
Branches 3143 3202 +59
==========================================
+ Hits 10449 10903 +454
+ Misses 1700 1577 -123
- Partials 3058 3075 +17 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was likely introduced in PR #815 when delaying the close of the socket based on the event loop adapter invoking a NATS C callback to indicate that it is safe to do so. The
libuvadapter is doing the right thing, however thelibeventwas not since it was creating a one-time event based onEV_TIMEOUTpassing the socket to close, however, in that mode the socket from the callback is always set to-1. We have to pass the socket to close though thenleobject.I also made the
natsLibevent_Detach()function schedule an event to ensure that a_freeCbis now invoked after execution of the_closeCb.Resolves #879
Signed-off-by: Ivan Kozlovic ivan@synadia.com