Skip to content

Conversation

kozlovic
Copy link
Member

@kozlovic kozlovic commented Jul 4, 2025

This is to make sure that we properly allocate the inbox with a very long prefix that is larger than the stack variable.

Signed-off-by: Ivan Kozlovic ivan@synadia.com

Resolves #884

This is to make sure that we properly allocate the inbox with a
very long prefix that is larger than the stack variable.

Resolves #884

Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
@kozlovic kozlovic requested a review from levb July 4, 2025 16:56
Copy link

codecov bot commented Jul 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.29%. Comparing base (1553d4a) to head (12c7d35).
Report is 72 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #885      +/-   ##
==========================================
+ Coverage   68.71%   70.29%   +1.58%     
==========================================
  Files          39       47       +8     
  Lines       15207    15558     +351     
  Branches     3143     3202      +59     
==========================================
+ Hits        10449    10936     +487     
+ Misses       1700     1540     -160     
- Partials     3058     3082      +24     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@kozlovic kozlovic requested review from derekcollison and removed request for levb July 12, 2025 01:18
Copy link
Member

@derekcollison derekcollison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kozlovic kozlovic merged commit 3720ca6 into main Jul 12, 2025
29 checks passed
@kozlovic kozlovic deleted the fix_884 branch July 12, 2025 18:23
github-actions bot pushed a commit that referenced this pull request Jul 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect use of sizeof() in the natsConnection_RequestMsg() function
2 participants